linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iio: trigger: stm32-timer: fix MODULE_ALIAS
@ 2021-11-25 18:28 Alyssa Ross
  2021-11-27 17:46 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Alyssa Ross @ 2021-11-25 18:28 UTC (permalink / raw)
  To: Jonathan Cameron, Lars-Peter Clausen, Maxime Coquelin,
	Alexandre Torgue, Benjamin Gaignard, Lee Jones
  Cc: Alyssa Ross, open list:IIO SUBSYSTEM AND DRIVERS,
	moderated list:ARM/STM32 ARCHITECTURE,
	moderated list:ARM/STM32 ARCHITECTURE, open list

modprobe can't handle spaces in aliases.

Fixes: 93fbe91b5521 ("iio: Add STM32 timer trigger driver")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
 drivers/iio/trigger/stm32-timer-trigger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
index 33083877cd19..4353b749ecef 100644
--- a/drivers/iio/trigger/stm32-timer-trigger.c
+++ b/drivers/iio/trigger/stm32-timer-trigger.c
@@ -912,6 +912,6 @@ static struct platform_driver stm32_timer_trigger_driver = {
 };
 module_platform_driver(stm32_timer_trigger_driver);
 
-MODULE_ALIAS("platform: stm32-timer-trigger");
+MODULE_ALIAS("platform:stm32-timer-trigger");
 MODULE_DESCRIPTION("STMicroelectronics STM32 Timer Trigger driver");
 MODULE_LICENSE("GPL v2");
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio: trigger: stm32-timer: fix MODULE_ALIAS
  2021-11-25 18:28 [PATCH] iio: trigger: stm32-timer: fix MODULE_ALIAS Alyssa Ross
@ 2021-11-27 17:46 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-11-27 17:46 UTC (permalink / raw)
  To: Alyssa Ross
  Cc: Lars-Peter Clausen, Maxime Coquelin, Alexandre Torgue,
	Benjamin Gaignard, Lee Jones,
	open list:IIO SUBSYSTEM AND DRIVERS,
	moderated list:ARM/STM32 ARCHITECTURE,
	moderated list:ARM/STM32 ARCHITECTURE, open list

On Thu, 25 Nov 2021 18:28:48 +0000
Alyssa Ross <hi@alyssa.is> wrote:

> modprobe can't handle spaces in aliases.
> 
> Fixes: 93fbe91b5521 ("iio: Add STM32 timer trigger driver")
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
Hi Alysaa,

Looks fine to me, but I'd like to give it a little longer on list before
taking it as a fix, particularly as this probably wants to get backported
to stable.

Thanks,

Jonathan

> ---
>  drivers/iio/trigger/stm32-timer-trigger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
> index 33083877cd19..4353b749ecef 100644
> --- a/drivers/iio/trigger/stm32-timer-trigger.c
> +++ b/drivers/iio/trigger/stm32-timer-trigger.c
> @@ -912,6 +912,6 @@ static struct platform_driver stm32_timer_trigger_driver = {
>  };
>  module_platform_driver(stm32_timer_trigger_driver);
>  
> -MODULE_ALIAS("platform: stm32-timer-trigger");
> +MODULE_ALIAS("platform:stm32-timer-trigger");
>  MODULE_DESCRIPTION("STMicroelectronics STM32 Timer Trigger driver");
>  MODULE_LICENSE("GPL v2");


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-27 17:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25 18:28 [PATCH] iio: trigger: stm32-timer: fix MODULE_ALIAS Alyssa Ross
2021-11-27 17:46 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).