From: Peilin Ye <yepeilin.cs@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Shuah Khan <shuah@kernel.org>,
Peilin Ye <peilin.ye@bytedance.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Hangbin Liu <liuhangbin@gmail.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] selftests/fib_tests: ping from dummy0 in fib_rp_filter_test()
Date: Mon, 29 Nov 2021 21:13:22 -0800 [thread overview]
Message-ID: <20211130051322.GA4450@bytedance> (raw)
In-Reply-To: <c19ebcb5-2e25-ce9c-af83-e934cc3d0996@gmail.com>
Hi David,
On Mon, Nov 29, 2021 at 06:16:48PM -0700, David Ahern wrote:
> On 11/29/21 5:49 PM, Peilin Ye wrote:
> > - run_cmd "ip netns exec ns1 ping -I dummy1 -w1 -c1 198.51.100.1"
> > + run_cmd "ip netns exec ns1 ping -I dummy0 -w1 -c1 198.51.100.1"
> > log_test $? 0 "rp_filter passes local packets"
>
> confused by the point of this test if you are going to change dummy1 to
> dummy0. dummy0 has 198.51.100.1 assigned to it, so the ping should
> always work.
Ah... Thanks for pointing this out, I'll try to figure out a different
way to test it in v3.
Thanks,
Peilin Ye
next prev parent reply other threads:[~2021-11-30 5:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 22:52 [PATCH net] selftests/fib_tests: ping from dummy0 in fib_rp_filter_test() Peilin Ye
2021-11-30 0:46 ` Peilin Ye
2021-11-30 0:49 ` [PATCH net v2] " Peilin Ye
2021-11-30 1:16 ` David Ahern
2021-11-30 5:13 ` Peilin Ye [this message]
2021-12-01 0:47 ` [PATCH net v3] selftests/fib_tests: Rework fib_rp_filter_test() Peilin Ye
2021-12-01 18:00 ` David Ahern
2021-12-01 19:35 ` Peilin Ye
2021-12-02 15:50 ` David Ahern
2021-12-03 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130051322.GA4450@bytedance \
--to=yepeilin.cs@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peilin.ye@bytedance.com \
--cc=shuah@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).