From: David Ahern <dsahern@gmail.com>
To: Peilin Ye <yepeilin.cs@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: Peilin Ye <peilin.ye@bytedance.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Hangbin Liu <liuhangbin@gmail.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] selftests/fib_tests: ping from dummy0 in fib_rp_filter_test()
Date: Mon, 29 Nov 2021 18:16:48 -0700 [thread overview]
Message-ID: <c19ebcb5-2e25-ce9c-af83-e934cc3d0996@gmail.com> (raw)
In-Reply-To: <20211130004905.4146-1-yepeilin.cs@gmail.com>
On 11/29/21 5:49 PM, Peilin Ye wrote:
> diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
> index 5abe92d55b69..b8bceae00f8e 100755
> --- a/tools/testing/selftests/net/fib_tests.sh
> +++ b/tools/testing/selftests/net/fib_tests.sh
> @@ -453,15 +453,19 @@ fib_rp_filter_test()
> $NS_EXEC sysctl -qw net.ipv4.conf.all.accept_local=1
> $NS_EXEC sysctl -qw net.ipv4.conf.all.route_localnet=1
>
> + $NS_EXEC tc qd add dev dummy0 parent root handle 1: fq_codel
> + $NS_EXEC tc filter add dev dummy0 parent 1: protocol arp basic action mirred egress redirect dev dummy1
> + $NS_EXEC tc filter add dev dummy0 parent 1: protocol ip basic action mirred egress redirect dev dummy1
> +
> $NS_EXEC tc qd add dev dummy1 parent root handle 1: fq_codel
> $NS_EXEC tc filter add dev dummy1 parent 1: protocol arp basic action mirred egress redirect dev lo
> $NS_EXEC tc filter add dev dummy1 parent 1: protocol ip basic action mirred egress redirect dev lo
> set +e
>
> - run_cmd "ip netns exec ns1 ping -I dummy1 -w1 -c1 198.51.100.1"
> + run_cmd "ip netns exec ns1 ping -I dummy0 -w1 -c1 198.51.100.1"
> log_test $? 0 "rp_filter passes local packets"
>
> - run_cmd "ip netns exec ns1 ping -I dummy1 -w1 -c1 127.0.0.1"
> + run_cmd "ip netns exec ns1 ping -I dummy0 -w1 -c1 127.0.0.1"
> log_test $? 0 "rp_filter passes loopback packets"
>
> cleanup
>
confused by the point of this test if you are going to change dummy1 to
dummy0. dummy0 has 198.51.100.1 assigned to it, so the ping should
always work.
next prev parent reply other threads:[~2021-11-30 1:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 22:52 [PATCH net] selftests/fib_tests: ping from dummy0 in fib_rp_filter_test() Peilin Ye
2021-11-30 0:46 ` Peilin Ye
2021-11-30 0:49 ` [PATCH net v2] " Peilin Ye
2021-11-30 1:16 ` David Ahern [this message]
2021-11-30 5:13 ` Peilin Ye
2021-12-01 0:47 ` [PATCH net v3] selftests/fib_tests: Rework fib_rp_filter_test() Peilin Ye
2021-12-01 18:00 ` David Ahern
2021-12-01 19:35 ` Peilin Ye
2021-12-02 15:50 ` David Ahern
2021-12-03 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c19ebcb5-2e25-ce9c-af83-e934cc3d0996@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peilin.ye@bytedance.com \
--cc=shuah@kernel.org \
--cc=xiyou.wangcong@gmail.com \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).