From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Zheyu Ma <zheyuma97@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Sasha Levin <sashal@kernel.org>,
rajur@chelsio.com, kuba@kernel.org, netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 4.19 12/17] net: chelsio: cxgb4vf: Fix an error code in cxgb4vf_pci_probe()
Date: Tue, 30 Nov 2021 09:52:36 -0500 [thread overview]
Message-ID: <20211130145243.946407-12-sashal@kernel.org> (raw)
In-Reply-To: <20211130145243.946407-1-sashal@kernel.org>
From: Zheyu Ma <zheyuma97@gmail.com>
[ Upstream commit b82d71c0f84a2e5ccaaa7571dfd5c69e0e2cfb4a ]
During the process of driver probing, probe function should return < 0
for failure, otherwise kernel will treat value == 0 as success.
Therefore, we should set err to -EINVAL when
adapter->registered_device_map is NULL. Otherwise kernel will assume
that driver has been successfully probed and will cause unexpected
errors.
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
index 15029a5e62b9b..3c3ff62e4fea5 100644
--- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
@@ -3202,6 +3202,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
}
if (adapter->registered_device_map == 0) {
dev_err(&pdev->dev, "could not register any net devices\n");
+ err = -EINVAL;
goto err_disable_interrupts;
}
--
2.33.0
next prev parent reply other threads:[~2021-11-30 15:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 14:52 [PATCH AUTOSEL 4.19 01/17] ASoC: mediatek: mt8173-rt5650: Rename Speaker control to Ext Spk Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 02/17] ASoC: qdsp6: q6adm: improve error reporting Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 03/17] ASoC: qdsp6: q6routing: validate port id before setting up route Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 04/17] xen/privcmd: make option visible in Kconfig Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 05/17] NFSv4.1: handle NFS4ERR_NOSPC by CREATE_SESSION Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 06/17] HID: multitouch: Fix Iiyama ProLite T1931SAW (0eef:0001 again!) Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 07/17] parisc: Provide an extru_safe() macro to extract unsigned bits Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 08/17] selftests/tc-testings: Be compatible with newer tc output Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 09/17] scsi: scsi_debug: Sanity check block descriptor length in resp_mode_select() Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 10/17] i2c: i801: Fix interrupt storm from SMB_ALERT signal Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 11/17] mmc: spi: Add device-tree SPI IDs Sasha Levin
2021-11-30 14:52 ` Sasha Levin [this message]
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 13/17] smb2: clarify rc initialization in smb2_reconnect Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 14/17] PM: hibernate: Fix snapshot partial write lengths Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 15/17] net: qed: fix the array may be out of bound Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 16/17] net: ptp: add a definition for the UDP port for IEEE 1588 general messages Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 17/17] fs: ntfs: Limit NTFS_RW to page sizes smaller than 64k Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130145243.946407-12-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rajur@chelsio.com \
--cc=stable@vger.kernel.org \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).