From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: zhangyue <zhangyue1@kylinos.cn>, Jakub Kicinski <kuba@kernel.org>,
Sasha Levin <sashal@kernel.org>,
aelior@marvell.com, manishc@marvell.com, davem@davemloft.net,
netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 4.19 15/17] net: qed: fix the array may be out of bound
Date: Tue, 30 Nov 2021 09:52:39 -0500 [thread overview]
Message-ID: <20211130145243.946407-15-sashal@kernel.org> (raw)
In-Reply-To: <20211130145243.946407-1-sashal@kernel.org>
From: zhangyue <zhangyue1@kylinos.cn>
[ Upstream commit 0435a4d08032c8fba2966cebdac870e22238cacc ]
If the variable 'p_bit->flags' is always 0,
the loop condition is always 0.
The variable 'j' may be greater than or equal to 32.
At this time, the array 'p_aeu->bits[32]' may be out
of bound.
Signed-off-by: zhangyue <zhangyue1@kylinos.cn>
Link: https://lore.kernel.org/r/20211125113610.273841-1-zhangyue1@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/net/ethernet/qlogic/qed/qed_int.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c
index 61d5d76545687..21704e34b962f 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_int.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
@@ -865,7 +865,7 @@ static int qed_int_deassertion(struct qed_hwfn *p_hwfn,
if (!parities)
continue;
- for (j = 0, bit_idx = 0; bit_idx < 32; j++) {
+ for (j = 0, bit_idx = 0; bit_idx < 32 && j < 32; j++) {
struct aeu_invert_reg_bit *p_bit = &p_aeu->bits[j];
if (qed_int_is_parity_flag(p_hwfn, p_bit) &&
@@ -903,7 +903,7 @@ static int qed_int_deassertion(struct qed_hwfn *p_hwfn,
* to current group, making them responsible for the
* previous assertion.
*/
- for (j = 0, bit_idx = 0; bit_idx < 32; j++) {
+ for (j = 0, bit_idx = 0; bit_idx < 32 && j < 32; j++) {
long unsigned int bitmask;
u8 bit, bit_len;
@@ -1201,7 +1201,7 @@ static void qed_int_sb_attn_init(struct qed_hwfn *p_hwfn,
memset(sb_info->parity_mask, 0, sizeof(u32) * NUM_ATTN_REGS);
for (i = 0; i < NUM_ATTN_REGS; i++) {
/* j is array index, k is bit index */
- for (j = 0, k = 0; k < 32; j++) {
+ for (j = 0, k = 0; k < 32 && j < 32; j++) {
struct aeu_invert_reg_bit *p_aeu;
p_aeu = &aeu_descs[i].bits[j];
--
2.33.0
next prev parent reply other threads:[~2021-11-30 15:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 14:52 [PATCH AUTOSEL 4.19 01/17] ASoC: mediatek: mt8173-rt5650: Rename Speaker control to Ext Spk Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 02/17] ASoC: qdsp6: q6adm: improve error reporting Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 03/17] ASoC: qdsp6: q6routing: validate port id before setting up route Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 04/17] xen/privcmd: make option visible in Kconfig Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 05/17] NFSv4.1: handle NFS4ERR_NOSPC by CREATE_SESSION Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 06/17] HID: multitouch: Fix Iiyama ProLite T1931SAW (0eef:0001 again!) Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 07/17] parisc: Provide an extru_safe() macro to extract unsigned bits Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 08/17] selftests/tc-testings: Be compatible with newer tc output Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 09/17] scsi: scsi_debug: Sanity check block descriptor length in resp_mode_select() Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 10/17] i2c: i801: Fix interrupt storm from SMB_ALERT signal Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 11/17] mmc: spi: Add device-tree SPI IDs Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 12/17] net: chelsio: cxgb4vf: Fix an error code in cxgb4vf_pci_probe() Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 13/17] smb2: clarify rc initialization in smb2_reconnect Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 14/17] PM: hibernate: Fix snapshot partial write lengths Sasha Levin
2021-11-30 14:52 ` Sasha Levin [this message]
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 16/17] net: ptp: add a definition for the UDP port for IEEE 1588 general messages Sasha Levin
2021-11-30 14:52 ` [PATCH AUTOSEL 4.19 17/17] fs: ntfs: Limit NTFS_RW to page sizes smaller than 64k Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130145243.946407-15-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=zhangyue1@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).