From: Pratyush Yadav <p.yadav@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Tero Kristo <kristo@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am642: Fix the L2 cache sets
Date: Fri, 3 Dec 2021 16:43:10 +0530 [thread overview]
Message-ID: <20211203111308.zfxczgywmjzplbha@ti.com> (raw)
In-Reply-To: <20211113043635.4296-1-nm@ti.com>
On 12/11/21 10:36PM, Nishanth Menon wrote:
> A53's L2 cache[1] on AM642[2] is 256KB. A53's L2 is fixed line length
> of 64 bytes and 16-way set-associative cache structure.
This time the commit message is correct :-)
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
>
> 256KB of L2 / 64 (line length) = 4096 ways
> 4096 ways / 16 = 256 sets
>
> Fix the l2 cache-sets.
>
> [1] https://developer.arm.com/documentation/ddi0500/j/Level-2-Memory-System/About-the-L2-memory-system?lang=en
> [2] https://www.ti.com/lit/pdf/spruim2
>
> Fixes: 8abae9389bdb ("arm64: dts: ti: Add support for AM642 SoC")
> Reported-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am642.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642.dtsi b/arch/arm64/boot/dts/ti/k3-am642.dtsi
> index e2b397c88401..8a76f4821b11 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am642.dtsi
> @@ -60,6 +60,6 @@ L2_0: l2-cache0 {
> cache-level = <2>;
> cache-size = <0x40000>;
> cache-line-size = <64>;
> - cache-sets = <512>;
> + cache-sets = <256>;
> };
> };
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2021-12-03 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 4:36 [PATCH] arm64: dts: ti: k3-am642: Fix the L2 cache sets Nishanth Menon
2021-12-03 11:13 ` Pratyush Yadav [this message]
2021-12-06 13:21 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203111308.zfxczgywmjzplbha@ti.com \
--to=p.yadav@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).