* [PATCH] PCI: mt7621: Kconfig: Convert driver into 'bool'
@ 2021-12-01 21:34 Sergio Paracuellos
2021-12-01 21:37 ` Guenter Roeck
2021-12-03 18:23 ` Bjorn Helgaas
0 siblings, 2 replies; 4+ messages in thread
From: Sergio Paracuellos @ 2021-12-01 21:34 UTC (permalink / raw)
To: linux-pci
Cc: tsbogend, lorenzo.pieralisi, bhelgaas, arnd, linux, linux-kernel
Driver is not ready yet to be compiled as a module since it depends on some
MIPS not exported symbols. We have the following current problems:
Building mips:allmodconfig ... failed
--------------
Error log:
ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o
ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
Temporarily move from 'tristate' to 'bool' after a better solution is ready.
Also RALINK is redundant because SOC_MT7621 already depends on it. Hence,
simplify condition.
Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver").
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
drivers/pci/controller/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 93b141110537..7fc5135ffbbf 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -332,8 +332,8 @@ config PCIE_APPLE
If unsure, say Y if you have an Apple Silicon system.
config PCIE_MT7621
- tristate "MediaTek MT7621 PCIe Controller"
- depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST)
+ bool "MediaTek MT7621 PCIe Controller"
+ depends on SOC_MT7621 || (MIPS && COMPILE_TEST)
select PHY_MT7621_PCI
default SOC_MT7621
help
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: mt7621: Kconfig: Convert driver into 'bool'
2021-12-01 21:34 [PATCH] PCI: mt7621: Kconfig: Convert driver into 'bool' Sergio Paracuellos
@ 2021-12-01 21:37 ` Guenter Roeck
2021-12-03 18:23 ` Bjorn Helgaas
1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2021-12-01 21:37 UTC (permalink / raw)
To: Sergio Paracuellos, linux-pci
Cc: tsbogend, lorenzo.pieralisi, bhelgaas, arnd, linux-kernel
On 12/1/21 1:34 PM, Sergio Paracuellos wrote:
> Driver is not ready yet to be compiled as a module since it depends on some
> MIPS not exported symbols. We have the following current problems:
>
> Building mips:allmodconfig ... failed
> --------------
> Error log:
> ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o
> ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
>
> Temporarily move from 'tristate' to 'bool' after a better solution is ready.
s/after/until/
>
> Also RALINK is redundant because SOC_MT7621 already depends on it. Hence,
> simplify condition.
>
> Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver").
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-and-Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/pci/controller/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 93b141110537..7fc5135ffbbf 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -332,8 +332,8 @@ config PCIE_APPLE
> If unsure, say Y if you have an Apple Silicon system.
>
> config PCIE_MT7621
> - tristate "MediaTek MT7621 PCIe Controller"
> - depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST)
> + bool "MediaTek MT7621 PCIe Controller"
> + depends on SOC_MT7621 || (MIPS && COMPILE_TEST)
> select PHY_MT7621_PCI
> default SOC_MT7621
> help
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: mt7621: Kconfig: Convert driver into 'bool'
2021-12-01 21:34 [PATCH] PCI: mt7621: Kconfig: Convert driver into 'bool' Sergio Paracuellos
2021-12-01 21:37 ` Guenter Roeck
@ 2021-12-03 18:23 ` Bjorn Helgaas
2021-12-04 9:00 ` Sergio Paracuellos
1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2021-12-03 18:23 UTC (permalink / raw)
To: Sergio Paracuellos
Cc: linux-pci, tsbogend, lorenzo.pieralisi, bhelgaas, arnd, linux,
linux-kernel
s/PCI: mt7621: Kconfig:/PCI: mt7621:/
in subject. You can run "git log --oneline
drivers/pci/controller/Kconfig" to learn the convention.
On Wed, Dec 01, 2021 at 10:34:02PM +0100, Sergio Paracuellos wrote:
> Driver is not ready yet to be compiled as a module since it depends on some
> MIPS not exported symbols. We have the following current problems:
> ...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: mt7621: Kconfig: Convert driver into 'bool'
2021-12-03 18:23 ` Bjorn Helgaas
@ 2021-12-04 9:00 ` Sergio Paracuellos
0 siblings, 0 replies; 4+ messages in thread
From: Sergio Paracuellos @ 2021-12-04 9:00 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: linux-pci, Thomas Bogendoerfer, Lorenzo Pieralisi, Bjorn Helgaas,
Arnd Bergmann, Guenter Roeck, linux-kernel
On Fri, Dec 3, 2021 at 7:23 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> s/PCI: mt7621: Kconfig:/PCI: mt7621:/
>
> in subject. You can run "git log --oneline
> drivers/pci/controller/Kconfig" to learn the convention.
Will take it into account from now, thanks.
Sent: https://lore.kernel.org/linux-pci/20211203192454.32624-1-sergio.paracuellos@gmail.com/T/#u
Best regards,
Sergio Paracuellos
>
> On Wed, Dec 01, 2021 at 10:34:02PM +0100, Sergio Paracuellos wrote:
> > Driver is not ready yet to be compiled as a module since it depends on some
> > MIPS not exported symbols. We have the following current problems:
> > ...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-04 9:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-01 21:34 [PATCH] PCI: mt7621: Kconfig: Convert driver into 'bool' Sergio Paracuellos
2021-12-01 21:37 ` Guenter Roeck
2021-12-03 18:23 ` Bjorn Helgaas
2021-12-04 9:00 ` Sergio Paracuellos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).