linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] staging: vt6655: remove unused variable byMinChannel
@ 2021-12-04 11:34 Alberto Merciai
  2021-12-05 11:03 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Alberto Merciai @ 2021-12-04 11:34 UTC (permalink / raw)
  To: alb3rt0.m3rciai
  Cc: Forest Bond, Greg Kroah-Hartman, Tommaso Merciai, Dan Carpenter,
	Karolina Drobnik, Aldas Taraškevičius, Lucas Henneman,
	linux-staging, linux-kernel

Remove set but not used variable byMinChannel.

Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
---

v1 -> v2
- Add Signed-off-by

 drivers/staging/vt6655/device.h      | 1 -
 drivers/staging/vt6655/device_main.c | 2 --
 2 files changed, 3 deletions(-)

diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 9e5f060f3784..b2aee3b8bc8d 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -200,7 +200,6 @@ struct vnt_private {
 	unsigned char byTopOFDMBasicRate;
 	unsigned char byTopCCKBasicRate;
 
-	unsigned char byMinChannel;
 	unsigned char byMaxChannel;
 
 	unsigned char preamble_type;
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 6c5140e29f6b..d008b22cb98a 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -227,8 +227,6 @@ static void device_init_registers(struct vnt_private *priv)
 
 	spin_unlock_irqrestore(&priv->lock, flags);
 
-	/* Get Channel range */
-	priv->byMinChannel = 1;
 	priv->byMaxChannel = CB_MAX_CHANNEL;
 
 	/* Get Antena */
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] staging: vt6655: remove unused variable byMinChannel
  2021-12-04 11:34 [PATCH v2] staging: vt6655: remove unused variable byMinChannel Alberto Merciai
@ 2021-12-05 11:03 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-12-05 11:03 UTC (permalink / raw)
  To: Alberto Merciai
  Cc: Forest Bond, Tommaso Merciai, Dan Carpenter, Karolina Drobnik,
	Aldas Taraškevičius, Lucas Henneman, linux-staging,
	linux-kernel

On Sat, Dec 04, 2021 at 12:34:04PM +0100, Alberto Merciai wrote:
> Remove set but not used variable byMinChannel.
> 
> Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
> ---
> 
> v1 -> v2
> - Add Signed-off-by

I have a number of patches from you for this driver, all in different
orders and some being obsoleted by others, making this impossible for me
to easily determine what is, and what is not, viable for applying and in
what order.

Can you please resend all of your pending patches, in a patch series,
properly numbered, so that I have a chance of understanding this?

I have now dropped all of your pending patches from my review queue.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-05 11:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-04 11:34 [PATCH v2] staging: vt6655: remove unused variable byMinChannel Alberto Merciai
2021-12-05 11:03 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).