* [RFC PATCH t-kristo-pm] HID: bpf: hid_bpf_add_report() can be static
@ 2021-12-04 15:28 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-12-04 15:28 UTC (permalink / raw)
To: Tero Kristo; +Cc: kbuild-all, linux-kernel
drivers/hid/hid-bpf.c:229:23: warning: symbol 'hid_bpf_add_report' was not declared. Should it be static?
drivers/hid/hid-bpf.c:257:6: warning: symbol 'hid_bpf_free_reports' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
hid-bpf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/hid/hid-bpf.c b/drivers/hid/hid-bpf.c
index b46b68d54ea80..6b39c48d3d85c 100644
--- a/drivers/hid/hid-bpf.c
+++ b/drivers/hid/hid-bpf.c
@@ -226,9 +226,9 @@ struct hid_bpf_parser_and_data {
struct hid_bpf_report_enum report_enum[HID_REPORT_TYPES];
};
-struct hid_bpf_report *hid_bpf_add_report(struct hid_bpf_parser_and_data *data,
- unsigned int type, unsigned int id,
- unsigned int application)
+static struct hid_bpf_report *hid_bpf_add_report(struct hid_bpf_parser_and_data *data,
+ unsigned int type, unsigned int id,
+ unsigned int application)
{
struct hid_bpf_report_enum *report_enum = data->report_enum + type;
struct hid_bpf_report *report;
@@ -254,7 +254,7 @@ struct hid_bpf_report *hid_bpf_add_report(struct hid_bpf_parser_and_data *data,
return report;
}
-void hid_bpf_free_reports(struct hid_bpf_parser_and_data *data)
+static void hid_bpf_free_reports(struct hid_bpf_parser_and_data *data)
{
unsigned i, j;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-12-04 15:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-04 15:28 [RFC PATCH t-kristo-pm] HID: bpf: hid_bpf_add_report() can be static kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).