* [PATCH] dt-bindings: i2c: aspeed: Drop stray '#interrupt-cells'
@ 2021-12-06 17:42 Rob Herring
2021-12-07 8:49 ` Thierry Reding
2021-12-16 21:27 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2021-12-06 17:42 UTC (permalink / raw)
To: Brendan Higgins, Benjamin Herrenschmidt, Joel Stanley,
Andrew Jeffery, Rayn Chen
Cc: devicetree, Thierry Reding, linux-i2c, openbmc, linux-arm-kernel,
linux-aspeed, linux-kernel
'#interrupt-cells' is not documented which causes a warning when
'unevaluatedProperties' is implemented. Unless the I2C controller is
also an interrupt controller, '#interrupt-cells' is not valid. This
doesn't appear to be the case from the driver, so just remove it from
the example.
Cc: Brendan Higgins <brendanhiggins@google.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: Rayn Chen <rayn_chen@aspeedtech.com>
Cc: linux-i2c@vger.kernel.org
Cc: openbmc@lists.ozlabs.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-aspeed@lists.ozlabs.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
index ea643e6c3ef5..f597f73ccd87 100644
--- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
@@ -63,7 +63,6 @@ examples:
i2c0: i2c-bus@40 {
#address-cells = <1>;
#size-cells = <0>;
- #interrupt-cells = <1>;
compatible = "aspeed,ast2500-i2c-bus";
reg = <0x40 0x40>;
clocks = <&syscon ASPEED_CLK_APB>;
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: i2c: aspeed: Drop stray '#interrupt-cells'
2021-12-06 17:42 [PATCH] dt-bindings: i2c: aspeed: Drop stray '#interrupt-cells' Rob Herring
@ 2021-12-07 8:49 ` Thierry Reding
2021-12-16 21:27 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2021-12-07 8:49 UTC (permalink / raw)
To: Rob Herring
Cc: Brendan Higgins, Benjamin Herrenschmidt, Joel Stanley,
Andrew Jeffery, Rayn Chen, devicetree, linux-i2c, openbmc,
linux-arm-kernel, linux-aspeed, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]
On Mon, Dec 06, 2021 at 11:42:37AM -0600, Rob Herring wrote:
> '#interrupt-cells' is not documented which causes a warning when
> 'unevaluatedProperties' is implemented. Unless the I2C controller is
> also an interrupt controller, '#interrupt-cells' is not valid. This
> doesn't appear to be the case from the driver, so just remove it from
> the example.
>
> Cc: Brendan Higgins <brendanhiggins@google.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Rayn Chen <rayn_chen@aspeedtech.com>
> Cc: linux-i2c@vger.kernel.org
> Cc: openbmc@lists.ozlabs.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-aspeed@lists.ozlabs.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 1 -
> 1 file changed, 1 deletion(-)
Interestingly I have a patch for this as well but it does the opposite
and adds interrupt-controller and #interrupt-cells. Upon closer
inspection I was tricked into this because the i2c-aspeed driver
includes linux/irqchip/chained_irq.h and linux/irqdomain.h and therefore
I assumed that it was indeed implementing an interrupt controller. But
none of the symbols in those files are ever used, so your version seems
to be correct.
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: i2c: aspeed: Drop stray '#interrupt-cells'
2021-12-06 17:42 [PATCH] dt-bindings: i2c: aspeed: Drop stray '#interrupt-cells' Rob Herring
2021-12-07 8:49 ` Thierry Reding
@ 2021-12-16 21:27 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2021-12-16 21:27 UTC (permalink / raw)
To: Rob Herring
Cc: Brendan Higgins, Benjamin Herrenschmidt, Joel Stanley,
Andrew Jeffery, Rayn Chen, devicetree, Thierry Reding, linux-i2c,
openbmc, linux-arm-kernel, linux-aspeed, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
On Mon, Dec 06, 2021 at 11:42:37AM -0600, Rob Herring wrote:
> '#interrupt-cells' is not documented which causes a warning when
> 'unevaluatedProperties' is implemented. Unless the I2C controller is
> also an interrupt controller, '#interrupt-cells' is not valid. This
> doesn't appear to be the case from the driver, so just remove it from
> the example.
>
> Cc: Brendan Higgins <brendanhiggins@google.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Rayn Chen <rayn_chen@aspeedtech.com>
> Cc: linux-i2c@vger.kernel.org
> Cc: openbmc@lists.ozlabs.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-aspeed@lists.ozlabs.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-16 21:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-06 17:42 [PATCH] dt-bindings: i2c: aspeed: Drop stray '#interrupt-cells' Rob Herring
2021-12-07 8:49 ` Thierry Reding
2021-12-16 21:27 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).