From: Nikita Travkin <nikita@trvn.ru>
To: mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org
Cc: bjorn.andersson@linaro.org, agross@kernel.org,
tdas@codeaurora.org, joonwoop@codeaurora.org,
svarbanov@mm-sol.com, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Nikita Travkin <nikita@trvn.ru>
Subject: [PATCH 2/4] clk: qcom: clk-rcg2: Make sure to not write d=0 to the NMD register
Date: Thu, 9 Dec 2021 21:37:18 +0500 [thread overview]
Message-ID: <20211209163720.106185-3-nikita@trvn.ru> (raw)
In-Reply-To: <20211209163720.106185-1-nikita@trvn.ru>
Sometimes calculation of d value may result in 0 because of the
rounding after integer division. This causes the following error:
[ 113.969689] camss_gp1_clk_src: rcg didn't update its configuration.
[ 113.969754] WARNING: CPU: 3 PID: 35 at drivers/clk/qcom/clk-rcg2.c:122 update_config+0xc8/0xdc
Make sure that D value is never zero.
Fixes: 7f891faf596e ("clk: qcom: clk-rcg2: Add support for duty-cycle for RCG")
Signed-off-by: Nikita Travkin <nikita@trvn.ru>
---
drivers/clk/qcom/clk-rcg2.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c
index 6964cf914b60..fdfd43e2a01b 100644
--- a/drivers/clk/qcom/clk-rcg2.c
+++ b/drivers/clk/qcom/clk-rcg2.c
@@ -424,6 +424,10 @@ static int clk_rcg2_set_duty_cycle(struct clk_hw *hw, struct clk_duty *duty)
if (d > mask)
d = mask;
+ /* Hardware can't handle d=0, make sure it's at least 1 */
+ if (!d)
+ d = 1;
+
if ((d / 2) > (n - m))
d = (n - m) * 2;
else if ((d / 2) < (m / 2))
--
2.30.2
next prev parent reply other threads:[~2021-12-09 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 16:37 [PATCH 0/4] Prepare general purpose clocks on msm8916 Nikita Travkin
2021-12-09 16:37 ` [PATCH 1/4] clk: qcom: clk-rcg2: Fail Duty-Cycle configuration if MND divider is not enabled Nikita Travkin
2022-01-08 0:52 ` Stephen Boyd
2022-01-08 7:25 ` Nikita Travkin
2022-01-10 20:14 ` Stephen Boyd
2022-01-26 15:14 ` Nikita Travkin
2022-02-17 22:37 ` Stephen Boyd
2022-02-19 6:32 ` Nikita Travkin
2021-12-09 16:37 ` Nikita Travkin [this message]
2022-01-08 0:56 ` [PATCH 2/4] clk: qcom: clk-rcg2: Make sure to not write d=0 to the NMD register Stephen Boyd
2022-01-08 7:29 ` Nikita Travkin
2021-12-09 16:37 ` [PATCH 3/4] pinctrl: qcom: msm8916: Allow CAMSS GP clocks to be muxed Nikita Travkin
2021-12-09 16:37 ` [PATCH 4/4] clk: qcom: gcc-msm8916: Add rates to the GP clocks Nikita Travkin
2022-01-08 0:53 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211209163720.106185-3-nikita@trvn.ru \
--to=nikita@trvn.ru \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=joonwoop@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=tdas@codeaurora.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).