* [PATCH] rcu: Remove unused rcu_state.boost
@ 2021-12-13 7:02 Neeraj Upadhyay
2021-12-13 19:41 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Neeraj Upadhyay @ 2021-12-13 7:02 UTC (permalink / raw)
To: paulmck, josh, rostedt, mathieu.desnoyers, jiangshanlai, joel
Cc: rcu, linux-kernel, urezki, frederic, boqun.feng, Neeraj Upadhyay
Signed-off-by: Neeraj Upadhyay <quic_neeraju@quicinc.com>
---
kernel/rcu/tree.h | 5 ++---
kernel/rcu/tree_plugin.h | 2 --
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
index 4b889081f4f4..caea946700f3 100644
--- a/kernel/rcu/tree.h
+++ b/kernel/rcu/tree.h
@@ -303,9 +303,8 @@ struct rcu_state {
/* The following fields are guarded by the root rcu_node's lock. */
- u8 boost ____cacheline_internodealigned_in_smp;
- /* Subject to priority boost. */
- unsigned long gp_seq; /* Grace-period sequence #. */
+ unsigned long gp_seq ____cacheline_internodealigned_in_smp;
+ /* Grace-period sequence #. */
unsigned long gp_max; /* Maximum GP duration in */
/* jiffies. */
struct task_struct *gp_kthread; /* Task for grace periods. */
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index 1439cb3680eb..54ef0e8c8742 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -1174,8 +1174,6 @@ static void rcu_spawn_one_boost_kthread(struct rcu_node *rnp)
if (rnp->boost_kthread_task || !rcu_scheduler_fully_active)
goto out;
- rcu_state.boost = 1;
-
t = kthread_create(rcu_boost_kthread, (void *)rnp,
"rcub/%d", rnp_index);
if (WARN_ON_ONCE(IS_ERR(t)))
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rcu: Remove unused rcu_state.boost
2021-12-13 7:02 [PATCH] rcu: Remove unused rcu_state.boost Neeraj Upadhyay
@ 2021-12-13 19:41 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2021-12-13 19:41 UTC (permalink / raw)
To: Neeraj Upadhyay
Cc: josh, rostedt, mathieu.desnoyers, jiangshanlai, joel, rcu,
linux-kernel, urezki, frederic, boqun.feng
On Mon, Dec 13, 2021 at 12:32:09PM +0530, Neeraj Upadhyay wrote:
> Signed-off-by: Neeraj Upadhyay <quic_neeraju@quicinc.com>
Good eyes! This has since been replaced by the ->can_boost field of
the rcu_torture_ops structure.
Queued for review and testing, thank you!
Thanx, Paul
> ---
> kernel/rcu/tree.h | 5 ++---
> kernel/rcu/tree_plugin.h | 2 --
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
> index 4b889081f4f4..caea946700f3 100644
> --- a/kernel/rcu/tree.h
> +++ b/kernel/rcu/tree.h
> @@ -303,9 +303,8 @@ struct rcu_state {
>
> /* The following fields are guarded by the root rcu_node's lock. */
>
> - u8 boost ____cacheline_internodealigned_in_smp;
> - /* Subject to priority boost. */
> - unsigned long gp_seq; /* Grace-period sequence #. */
> + unsigned long gp_seq ____cacheline_internodealigned_in_smp;
> + /* Grace-period sequence #. */
> unsigned long gp_max; /* Maximum GP duration in */
> /* jiffies. */
> struct task_struct *gp_kthread; /* Task for grace periods. */
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 1439cb3680eb..54ef0e8c8742 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -1174,8 +1174,6 @@ static void rcu_spawn_one_boost_kthread(struct rcu_node *rnp)
> if (rnp->boost_kthread_task || !rcu_scheduler_fully_active)
> goto out;
>
> - rcu_state.boost = 1;
> -
> t = kthread_create(rcu_boost_kthread, (void *)rnp,
> "rcub/%d", rnp_index);
> if (WARN_ON_ONCE(IS_ERR(t)))
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-13 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-13 7:02 [PATCH] rcu: Remove unused rcu_state.boost Neeraj Upadhyay
2021-12-13 19:41 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).