* [PATCH infiniband-next] drivers/infiniband: remove redundant err variable
@ 2021-12-15 6:06 cgel.zte
2021-12-15 7:05 ` [External] : " Devesh Sharma
2021-12-16 9:03 ` [PATCH infiniband-next] drivers/infiniband: " Zhu Yanjun
0 siblings, 2 replies; 7+ messages in thread
From: cgel.zte @ 2021-12-15 6:06 UTC (permalink / raw)
To: zyjzyj2000
Cc: dledford, jgg, linux-rdma, linux-kernel, Minghao Chi, Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
Return value directly instead of taking this
in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
index 2cb810cb890a..f557150bd59a 100644
--- a/drivers/infiniband/sw/rxe/rxe_net.c
+++ b/drivers/infiniband/sw/rxe/rxe_net.c
@@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid)
{
- int err;
unsigned char ll_addr[ETH_ALEN];
ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
- err = dev_mc_add(rxe->ndev, ll_addr);
- return err;
+ return dev_mc_add(rxe->ndev, ll_addr);
}
int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid)
{
- int err;
unsigned char ll_addr[ETH_ALEN];
ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
- err = dev_mc_del(rxe->ndev, ll_addr);
- return err;
+ return dev_mc_del(rxe->ndev, ll_addr);
}
static struct dst_entry *rxe_find_route4(struct net_device *ndev,
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [External] : [PATCH infiniband-next] drivers/infiniband: remove redundant err variable
2021-12-15 6:06 [PATCH infiniband-next] drivers/infiniband: remove redundant err variable cgel.zte
@ 2021-12-15 7:05 ` Devesh Sharma
2021-12-15 7:52 ` [PATCH for-next v2] RDMA/rxe: " cgel.zte
2021-12-16 9:03 ` [PATCH infiniband-next] drivers/infiniband: " Zhu Yanjun
1 sibling, 1 reply; 7+ messages in thread
From: Devesh Sharma @ 2021-12-15 7:05 UTC (permalink / raw)
To: cgel.zte, zyjzyj2000
Cc: dledford, jgg, linux-rdma, linux-kernel, Minghao Chi, Zeal Robot
> -----Original Message-----
> From: cgel.zte@gmail.com <cgel.zte@gmail.com>
> Sent: Wednesday, December 15, 2021 11:36 AM
> To: zyjzyj2000@gmail.com
> Cc: dledford@redhat.com; jgg@ziepe.ca; linux-rdma@vger.kernel.org; linux-
> kernel@vger.kernel.org; Minghao Chi <chi.minghao@zte.com.cn>; Zeal
> Robot <zealci@zte.com.cn>
> Subject: [External] : [PATCH infiniband-next] drivers/infiniband: remove
Change the subject line
[PATCH for-next] RDMA/rxe: ....
> redundant err variable
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value directly instead of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
> b/drivers/infiniband/sw/rxe/rxe_net.c
> index 2cb810cb890a..f557150bd59a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
>
> int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid) {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_add(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_add(rxe->ndev, ll_addr);
> }
>
> int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid) {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_del(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_del(rxe->ndev, ll_addr);
> }
>
> static struct dst_entry *rxe_find_route4(struct net_device *ndev,
> --
> 2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH for-next v2] RDMA/rxe: remove redundant err variable
2021-12-15 7:05 ` [External] : " Devesh Sharma
@ 2021-12-15 7:52 ` cgel.zte
2021-12-15 8:40 ` [External] : " Devesh Sharma
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: cgel.zte @ 2021-12-15 7:52 UTC (permalink / raw)
To: devesh.s.sharma
Cc: cgel.zte, chi.minghao, dledford, jgg, linux-kernel, linux-rdma,
zealci, zyjzyj2000
From: Minghao Chi <chi.minghao@zte.com.cn>
Return value directly instead of taking this
in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
b/drivers/infiniband/sw/rxe/rxe_net.c
index 2cb810cb890a..f557150bd59a 100644
--- a/drivers/infiniband/sw/rxe/rxe_net.c
+++ b/drivers/infiniband/sw/rxe/rxe_net.c
@@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid)
{
- int err;
unsigned char ll_addr[ETH_ALEN];
ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
- err = dev_mc_add(rxe->ndev, ll_addr);
- return err;
+ return dev_mc_add(rxe->ndev, ll_addr);
}
int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid)
{
- int err;
unsigned char ll_addr[ETH_ALEN];
ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
- err = dev_mc_del(rxe->ndev, ll_addr);
- return err;
+ return dev_mc_del(rxe->ndev, ll_addr);
}
static struct dst_entry *rxe_find_route4(struct net_device *ndev,
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [External] : [PATCH for-next v2] RDMA/rxe: remove redundant err variable
2021-12-15 7:52 ` [PATCH for-next v2] RDMA/rxe: " cgel.zte
@ 2021-12-15 8:40 ` Devesh Sharma
2021-12-15 12:36 ` Zhu Yanjun
2022-01-05 17:54 ` Jason Gunthorpe
2 siblings, 0 replies; 7+ messages in thread
From: Devesh Sharma @ 2021-12-15 8:40 UTC (permalink / raw)
To: cgel.zte
Cc: chi.minghao, dledford, jgg, linux-kernel, linux-rdma, zealci, zyjzyj2000
> -----Original Message-----
> From: cgel.zte@gmail.com <cgel.zte@gmail.com>
> Sent: Wednesday, December 15, 2021 1:23 PM
> To: Devesh Sharma <devesh.s.sharma@oracle.com>
> Cc: cgel.zte@gmail.com; chi.minghao@zte.com.cn; dledford@redhat.com;
> jgg@ziepe.ca; linux-kernel@vger.kernel.org; linux-rdma@vger.kernel.org;
> zealci@zte.com.cn; zyjzyj2000@gmail.com
> Subject: [External] : [PATCH for-next v2] RDMA/rxe: remove redundant err
> variable
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value directly instead of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
> b/drivers/infiniband/sw/rxe/rxe_net.c
> index 2cb810cb890a..f557150bd59a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
>
> int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid) {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_add(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_add(rxe->ndev, ll_addr);
> }
>
> int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid) {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_del(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_del(rxe->ndev, ll_addr);
> }
>
LGTM
Reviewed-by: Devesh Sharma <Devesh.s.sharma@oracle.com>
> static struct dst_entry *rxe_find_route4(struct net_device *ndev,
> --
> 2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH for-next v2] RDMA/rxe: remove redundant err variable
2021-12-15 7:52 ` [PATCH for-next v2] RDMA/rxe: " cgel.zte
2021-12-15 8:40 ` [External] : " Devesh Sharma
@ 2021-12-15 12:36 ` Zhu Yanjun
2022-01-05 17:54 ` Jason Gunthorpe
2 siblings, 0 replies; 7+ messages in thread
From: Zhu Yanjun @ 2021-12-15 12:36 UTC (permalink / raw)
To: cgel.zte
Cc: devesh.s.sharma, chi.minghao, Doug Ledford, Jason Gunthorpe,
LKML, RDMA mailing list, zealci
On Wed, Dec 15, 2021 at 3:53 PM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value directly instead of taking this
> in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Thanks.
Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>
Zhu Yanjun
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
> b/drivers/infiniband/sw/rxe/rxe_net.c
> index 2cb810cb890a..f557150bd59a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
>
> int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid)
> {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_add(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_add(rxe->ndev, ll_addr);
> }
>
> int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid)
> {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_del(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_del(rxe->ndev, ll_addr);
> }
>
> static struct dst_entry *rxe_find_route4(struct net_device *ndev,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH infiniband-next] drivers/infiniband: remove redundant err variable
2021-12-15 6:06 [PATCH infiniband-next] drivers/infiniband: remove redundant err variable cgel.zte
2021-12-15 7:05 ` [External] : " Devesh Sharma
@ 2021-12-16 9:03 ` Zhu Yanjun
1 sibling, 0 replies; 7+ messages in thread
From: Zhu Yanjun @ 2021-12-16 9:03 UTC (permalink / raw)
To: cgel.zte
Cc: Doug Ledford, Jason Gunthorpe, RDMA mailing list, LKML,
Minghao Chi, Zeal Robot
On Wed, Dec 15, 2021 at 2:06 PM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value directly instead of taking this
> in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Thanks.
Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>
Zhu Yanjun
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
> index 2cb810cb890a..f557150bd59a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
>
> int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid)
> {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_add(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_add(rxe->ndev, ll_addr);
> }
>
> int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid)
> {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_del(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_del(rxe->ndev, ll_addr);
> }
>
> static struct dst_entry *rxe_find_route4(struct net_device *ndev,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH for-next v2] RDMA/rxe: remove redundant err variable
2021-12-15 7:52 ` [PATCH for-next v2] RDMA/rxe: " cgel.zte
2021-12-15 8:40 ` [External] : " Devesh Sharma
2021-12-15 12:36 ` Zhu Yanjun
@ 2022-01-05 17:54 ` Jason Gunthorpe
2 siblings, 0 replies; 7+ messages in thread
From: Jason Gunthorpe @ 2022-01-05 17:54 UTC (permalink / raw)
To: cgel.zte
Cc: devesh.s.sharma, chi.minghao, dledford, linux-kernel, linux-rdma,
zealci, zyjzyj2000
On Wed, Dec 15, 2021 at 07:52:58AM +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value directly instead of taking this
> in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-01-05 17:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 6:06 [PATCH infiniband-next] drivers/infiniband: remove redundant err variable cgel.zte
2021-12-15 7:05 ` [External] : " Devesh Sharma
2021-12-15 7:52 ` [PATCH for-next v2] RDMA/rxe: " cgel.zte
2021-12-15 8:40 ` [External] : " Devesh Sharma
2021-12-15 12:36 ` Zhu Yanjun
2022-01-05 17:54 ` Jason Gunthorpe
2021-12-16 9:03 ` [PATCH infiniband-next] drivers/infiniband: " Zhu Yanjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).