* [PATCH v3] drm/tilcdc: add const to of_device_id
@ 2021-12-16 9:55 Xiang wangx
2021-12-16 10:24 ` Jyri Sarha
0 siblings, 1 reply; 2+ messages in thread
From: Xiang wangx @ 2021-12-16 9:55 UTC (permalink / raw)
To: jyri.sarha; +Cc: tomba, airlied, daniel, dri-devel, linux-kernel, Xiang wangx
struct of_device_id should normally be const.
Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
---
Changes since v1
* add const in line 63
Changes since v2
* removed line 63
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 3ddb7c710a3d..cc567c87057d 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -60,8 +60,6 @@ void tilcdc_module_cleanup(struct tilcdc_module *mod)
list_del(&mod->list);
}
-static struct of_device_id tilcdc_of_match[];
-
static int tilcdc_atomic_check(struct drm_device *dev,
struct drm_atomic_state *state)
{
@@ -587,7 +585,7 @@ static int tilcdc_pdev_remove(struct platform_device *pdev)
return 0;
}
-static struct of_device_id tilcdc_of_match[] = {
+static const struct of_device_id tilcdc_of_match[] = {
{ .compatible = "ti,am33xx-tilcdc", },
{ .compatible = "ti,da850-tilcdc", },
{ },
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] drm/tilcdc: add const to of_device_id
2021-12-16 9:55 [PATCH v3] drm/tilcdc: add const to of_device_id Xiang wangx
@ 2021-12-16 10:24 ` Jyri Sarha
0 siblings, 0 replies; 2+ messages in thread
From: Jyri Sarha @ 2021-12-16 10:24 UTC (permalink / raw)
To: Xiang wangx; +Cc: tomba, airlied, daniel, dri-devel, linux-kernel
On 2021-12-16 11:55, Xiang wangx wrote:
> struct of_device_id should normally be const.
>
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>
Thanks,
Jyri
> ---
>
> Changes since v1
> * add const in line 63
>
> Changes since v2
> * removed line 63
>
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 3ddb7c710a3d..cc567c87057d 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -60,8 +60,6 @@ void tilcdc_module_cleanup(struct tilcdc_module *mod)
> list_del(&mod->list);
> }
>
> -static struct of_device_id tilcdc_of_match[];
> -
> static int tilcdc_atomic_check(struct drm_device *dev,
> struct drm_atomic_state *state)
> {
> @@ -587,7 +585,7 @@ static int tilcdc_pdev_remove(struct
> platform_device *pdev)
> return 0;
> }
>
> -static struct of_device_id tilcdc_of_match[] = {
> +static const struct of_device_id tilcdc_of_match[] = {
> { .compatible = "ti,am33xx-tilcdc", },
> { .compatible = "ti,da850-tilcdc", },
> { },
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-16 10:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 9:55 [PATCH v3] drm/tilcdc: add const to of_device_id Xiang wangx
2021-12-16 10:24 ` Jyri Sarha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).