* [PATCH] MIPS: drop selected EARLY_PRINTK configs for MACH_REALTEK_RTL
@ 2021-12-15 20:06 Sander Vanheule
2021-12-16 15:03 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Sander Vanheule @ 2021-12-15 20:06 UTC (permalink / raw)
To: linux-mips
Cc: Thomas Bogendoerfer, linux-kernel, Sander Vanheule,
Lukas Bulwahn, Bert Vermeulen
MACH_REALTEK_RTL declares that the system supports early printk , but
this is not actually implemented as intended. The system is left with a
non-functional early0 console because the setup_8250_early_printk_port()
call provided for MIPS_GENERIC is never used to set this up. Generic
ns16550a earlycon works, so devices should use that for early output.
This means that SYS_HAS_EARLY_PRINTK and USE_GENERIC_EARLY_PRINTK_8250
do not need to be selected.
Additionally, as reported by Lukas Bulwahn, the selected symbol
SYS_HAS_EARLY_PRINTK_8250 does not actually exist, so should also be
dropped.
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Bert Vermeulen <bert@biot.com>
Signed-off-by: Sander Vanheule <sander@svanheule.net>
---
arch/mips/Kconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 63eb66a22691..9a3a2330fc69 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -642,9 +642,6 @@ config MACH_REALTEK_RTL
select SYS_SUPPORTS_MIPS16
select SYS_SUPPORTS_MULTITHREADING
select SYS_SUPPORTS_VPE_LOADER
- select SYS_HAS_EARLY_PRINTK
- select SYS_HAS_EARLY_PRINTK_8250
- select USE_GENERIC_EARLY_PRINTK_8250
select BOOT_RAW
select PINCTRL
select USE_OF
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: drop selected EARLY_PRINTK configs for MACH_REALTEK_RTL
2021-12-15 20:06 [PATCH] MIPS: drop selected EARLY_PRINTK configs for MACH_REALTEK_RTL Sander Vanheule
@ 2021-12-16 15:03 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2021-12-16 15:03 UTC (permalink / raw)
To: Sander Vanheule; +Cc: linux-mips, linux-kernel, Lukas Bulwahn, Bert Vermeulen
On Wed, Dec 15, 2021 at 09:06:02PM +0100, Sander Vanheule wrote:
> MACH_REALTEK_RTL declares that the system supports early printk , but
> this is not actually implemented as intended. The system is left with a
> non-functional early0 console because the setup_8250_early_printk_port()
> call provided for MIPS_GENERIC is never used to set this up. Generic
> ns16550a earlycon works, so devices should use that for early output.
> This means that SYS_HAS_EARLY_PRINTK and USE_GENERIC_EARLY_PRINTK_8250
> do not need to be selected.
>
> Additionally, as reported by Lukas Bulwahn, the selected symbol
> SYS_HAS_EARLY_PRINTK_8250 does not actually exist, so should also be
> dropped.
>
> Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Cc: Bert Vermeulen <bert@biot.com>
> Signed-off-by: Sander Vanheule <sander@svanheule.net>
> ---
> arch/mips/Kconfig | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 63eb66a22691..9a3a2330fc69 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -642,9 +642,6 @@ config MACH_REALTEK_RTL
> select SYS_SUPPORTS_MIPS16
> select SYS_SUPPORTS_MULTITHREADING
> select SYS_SUPPORTS_VPE_LOADER
> - select SYS_HAS_EARLY_PRINTK
> - select SYS_HAS_EARLY_PRINTK_8250
> - select USE_GENERIC_EARLY_PRINTK_8250
> select BOOT_RAW
> select PINCTRL
> select USE_OF
> --
> 2.33.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-16 15:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 20:06 [PATCH] MIPS: drop selected EARLY_PRINTK configs for MACH_REALTEK_RTL Sander Vanheule
2021-12-16 15:03 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).