From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH net-next v7 7/9] net: lan966x: Add vlan support.
Date: Fri, 17 Dec 2021 18:14:35 +0000 [thread overview]
Message-ID: <20211217181434.mfnur3nucfiykgto@skbuf> (raw)
In-Reply-To: <20211217155353.460594-8-horatiu.vultur@microchip.com>
On Fri, Dec 17, 2021 at 04:53:51PM +0100, Horatiu Vultur wrote:
> @@ -120,7 +124,12 @@ static void lan966x_port_bridge_leave(struct lan966x_port *port,
> if (!lan966x->bridge_mask)
> lan966x->bridge = NULL;
>
> - lan966x_mac_cpu_learn(lan966x, port->dev->dev_addr, PORT_PVID);
> + /* Set the port back to host mode */
> + lan966x_vlan_port_set_vlan_aware(port, false);
> + lan966x_vlan_port_set_vid(port, HOST_PVID, false, false);
> + lan966x_vlan_port_apply(port);
> +
> + lan966x_mac_cpu_learn(lan966x, port->dev->dev_addr, HOST_PVID);
Do you still need to re-learn the port MAC address?
> }
next prev parent reply other threads:[~2021-12-17 18:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 15:53 [PATCH net-next v7 0/9] net: lan966x: Add switchdev and vlan support Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 1/9] net: lan966x: Add registers that are used for switch and vlan functionality Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 2/9] dt-bindings: net: lan966x: Extend with the analyzer interrupt Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 3/9] net: lan966x: add support for interrupts from analyzer Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 4/9] net: lan966x: More MAC table functionality Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 5/9] net: lan966x: Remove .ndo_change_rx_flags Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 6/9] net: lan966x: Add support to offload the forwarding Horatiu Vultur
2021-12-17 17:44 ` Vladimir Oltean
2021-12-18 12:56 ` Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 7/9] net: lan966x: Add vlan support Horatiu Vultur
2021-12-17 18:14 ` Vladimir Oltean [this message]
2021-12-18 13:00 ` Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 8/9] net: lan966x: Extend switchdev bridge flags Horatiu Vultur
2021-12-17 17:40 ` Vladimir Oltean
2021-12-18 12:55 ` Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 9/9] net: lan966x: Extend switchdev with fdb support Horatiu Vultur
2021-12-17 18:12 ` Vladimir Oltean
2021-12-18 13:00 ` Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217181434.mfnur3nucfiykgto@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).