From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH net-next v7 9/9] net: lan966x: Extend switchdev with fdb support
Date: Sat, 18 Dec 2021 14:00:14 +0100 [thread overview]
Message-ID: <20211218130014.yb5wyfbyk4qv6ck4@soft-dev3-1.localhost> (raw)
In-Reply-To: <20211217181235.wquhfoq6qyqsfkxp@skbuf>
The 12/17/2021 18:12, Vladimir Oltean wrote:
>
> On Fri, Dec 17, 2021 at 04:53:53PM +0100, Horatiu Vultur wrote:
> > Extend lan966x driver with fdb support by implementing the switchdev
> > calls SWITCHDEV_FDB_ADD_TO_DEVICE and SWITCHDEV_FDB_DEL_TO_DEVICE.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
>
> Looks pretty good. Just one question, since I can't figure this out by
> looking at the code. Is the CPU port in the unknown unicast flood mask
> currently?
It is not. Because under a bridge can be only lan966x ports so the
HW will do already the flooding of the frames.
>
> > .../net/ethernet/microchip/lan966x/Makefile | 2 +-
> > .../ethernet/microchip/lan966x/lan966x_fdb.c | 244 ++++++++++++++++++
> > .../ethernet/microchip/lan966x/lan966x_main.c | 5 +
> > .../ethernet/microchip/lan966x/lan966x_main.h | 14 +
> > .../microchip/lan966x/lan966x_switchdev.c | 21 ++
> > .../ethernet/microchip/lan966x/lan966x_vlan.c | 15 +-
> > 6 files changed, 298 insertions(+), 3 deletions(-)
> > create mode 100644 drivers/net/ethernet/microchip/lan966x/lan966x_fdb.c
> (...)
> > +static void lan966x_fdb_add_entry(struct lan966x *lan966x,
> > + struct switchdev_notifier_fdb_info *fdb_info)
> > +{
> > + struct lan966x_fdb_entry *fdb_entry;
> > +
> > + fdb_entry = lan966x_fdb_find_entry(lan966x, fdb_info);
> > + if (fdb_entry) {
> > + fdb_entry->references++;
> > + return;
> > + }
> > +
> > + fdb_entry = kzalloc(sizeof(*fdb_entry), GFP_KERNEL);
> > + if (!fdb_entry)
> > + return;
> > +
> > + memcpy(fdb_entry->mac, fdb_info->addr, ETH_ALEN);
>
> ether_addr_copy
>
> > + fdb_entry->vid = fdb_info->vid;
> > + fdb_entry->references = 1;
> > + list_add_tail(&fdb_entry->list, &lan966x->fdb_entries);
> > +}
--
/Horatiu
prev parent reply other threads:[~2021-12-18 12:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 15:53 [PATCH net-next v7 0/9] net: lan966x: Add switchdev and vlan support Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 1/9] net: lan966x: Add registers that are used for switch and vlan functionality Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 2/9] dt-bindings: net: lan966x: Extend with the analyzer interrupt Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 3/9] net: lan966x: add support for interrupts from analyzer Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 4/9] net: lan966x: More MAC table functionality Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 5/9] net: lan966x: Remove .ndo_change_rx_flags Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 6/9] net: lan966x: Add support to offload the forwarding Horatiu Vultur
2021-12-17 17:44 ` Vladimir Oltean
2021-12-18 12:56 ` Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 7/9] net: lan966x: Add vlan support Horatiu Vultur
2021-12-17 18:14 ` Vladimir Oltean
2021-12-18 13:00 ` Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 8/9] net: lan966x: Extend switchdev bridge flags Horatiu Vultur
2021-12-17 17:40 ` Vladimir Oltean
2021-12-18 12:55 ` Horatiu Vultur
2021-12-17 15:53 ` [PATCH net-next v7 9/9] net: lan966x: Extend switchdev with fdb support Horatiu Vultur
2021-12-17 18:12 ` Vladimir Oltean
2021-12-18 13:00 ` Horatiu Vultur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211218130014.yb5wyfbyk4qv6ck4@soft-dev3-1.localhost \
--to=horatiu.vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).