linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dma: Revert "make dma pool to use kmalloc_node"
@ 2021-12-21 11:07 Christian König
  0 siblings, 0 replies; only message in thread
From: Christian König @ 2021-12-21 11:07 UTC (permalink / raw)
  To: akpm, linux-mm, linux-kernel, hch

This reverts commit 2618c60b8b5836b73e8deb385a036820744d256d.

While working myself into the dmapool code I've found this little odd
kmalloc_node().

What basically happens here is that we allocate the housekeeping structure
on the numa node where the device is attached to. Since the device is never
doing DMA to or from that memory this doesn't seem to make sense at all.

So while this doesn't seem to cause much harm it's probably cleaner to
revert the change for consistency.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 mm/dmapool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/dmapool.c b/mm/dmapool.c
index 64b537b3ccb0..a7eb5d0eb2da 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -152,7 +152,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev,
 	else if ((boundary < size) || (boundary & (boundary - 1)))
 		return NULL;
 
-	retval = kmalloc_node(sizeof(*retval), GFP_KERNEL, dev_to_node(dev));
+	retval = kmalloc(sizeof(*retval), GFP_KERNEL);
 	if (!retval)
 		return retval;
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-12-21 11:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-21 11:07 [PATCH] dma: Revert "make dma pool to use kmalloc_node" Christian König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).