* [PATCH] ipmi: ssif: replace strlcpy with strscpy
@ 2021-12-22 3:27 Jason Wang
2021-12-22 14:01 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2021-12-22 3:27 UTC (permalink / raw)
To: minyard; +Cc: openipmi-developer, linux-kernel, Jason Wang
The strlcpy should not be used because it doesn't limit the source
length. So that it will lead some potential bugs.
But the strscpy doesn't require reading memory from the src string
beyond the specified "count" bytes, and since the return value is
easier to error-check than strlcpy()'s. In addition, the implementation
is robust to the string changing out from underneath it, unlike the
current strlcpy() implementation.
Thus, replace strlcpy with strscpy.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
drivers/char/ipmi/ipmi_ssif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index 48aab77abebf..ba779f1abb5b 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -1354,7 +1354,7 @@ static int ssif_detect(struct i2c_client *client, struct i2c_board_info *info)
if (rv)
rv = -ENODEV;
else
- strlcpy(info->type, DEVICE_NAME, I2C_NAME_SIZE);
+ strscpy(info->type, DEVICE_NAME, I2C_NAME_SIZE);
kfree(resp);
return rv;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipmi: ssif: replace strlcpy with strscpy
2021-12-22 3:27 [PATCH] ipmi: ssif: replace strlcpy with strscpy Jason Wang
@ 2021-12-22 14:01 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2021-12-22 14:01 UTC (permalink / raw)
To: Jason Wang; +Cc: openipmi-developer, linux-kernel
On Wed, Dec 22, 2021 at 11:27:07AM +0800, Jason Wang wrote:
> The strlcpy should not be used because it doesn't limit the source
> length. So that it will lead some potential bugs.
>
> But the strscpy doesn't require reading memory from the src string
> beyond the specified "count" bytes, and since the return value is
> easier to error-check than strlcpy()'s. In addition, the implementation
> is robust to the string changing out from underneath it, unlike the
> current strlcpy() implementation.
>
> Thus, replace strlcpy with strscpy.
Ok, thanks for the patch.
-corey
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/char/ipmi/ipmi_ssif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index 48aab77abebf..ba779f1abb5b 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1354,7 +1354,7 @@ static int ssif_detect(struct i2c_client *client, struct i2c_board_info *info)
> if (rv)
> rv = -ENODEV;
> else
> - strlcpy(info->type, DEVICE_NAME, I2C_NAME_SIZE);
> + strscpy(info->type, DEVICE_NAME, I2C_NAME_SIZE);
> kfree(resp);
> return rv;
> }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-22 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-22 3:27 [PATCH] ipmi: ssif: replace strlcpy with strscpy Jason Wang
2021-12-22 14:01 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).