* [PATCH v4] fjes: Check for error irq
@ 2021-12-23 12:16 Jiasheng Jiang
0 siblings, 0 replies; only message in thread
From: Jiasheng Jiang @ 2021-12-23 12:16 UTC (permalink / raw)
To: andy.shevchenko, davem, kuba, yangyingliang, sashal
Cc: netdev, linux-kernel, Jiasheng Jiang
The platform_get_irq() is possible to fail.
So the return value needs to check to prevent the use of error irq
number.
Fixes: 658d439b2292 ("fjes: Introduce FUJITSU Extended Socket Network Device driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:
v3 -> v4
*Change 1. Using error variable to check.
*Change 2. Correct the word.
*Change 3. Add new commit message.
---
drivers/net/fjes/fjes_main.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index e449d9466122..17f2fd937e4d 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -1268,7 +1268,12 @@ static int fjes_probe(struct platform_device *plat_dev)
}
hw->hw_res.start = res->start;
hw->hw_res.size = resource_size(res);
- hw->hw_res.irq = platform_get_irq(plat_dev, 0);
+
+ err = platform_get_irq(plat_dev, 0);
+ if (err < 0)
+ goto err_free_control_wq;
+ hw->hw_res.irq = err;
+
err = fjes_hw_init(&adapter->hw);
if (err)
goto err_free_control_wq;
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-12-23 12:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-23 12:16 [PATCH v4] fjes: Check for error irq Jiasheng Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).