* [atishp04:isa_ext_support 3/4] arch/riscv/kernel/cpufeature.c:82:24: warning: address of array 'edata->dtprop' will always evaluate to 'true'
@ 2021-12-27 19:19 kernel test robot
2021-12-28 8:37 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-12-27 19:19 UTC (permalink / raw)
To: Atish Patra; +Cc: llvm, kbuild-all, Atish Patra, linux-kernel
tree: https://github.com/atishp04/linux isa_ext_support
head: cf2f3fa532aa7c672f681ca0685046c738bfb45f
commit: ae97a995345b68c472f3a904fc8fbefaa97ae26a [3/4] RISC-V: Provide a framework for parsing multi-letter ISA extensions
config: riscv-randconfig-c006-20211226 (https://download.01.org/0day-ci/archive/20211228/202112280309.fgjGevFd-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 0c553cc1af2e4c14100df6cf4a6fc91987e778e6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/atishp04/linux/commit/ae97a995345b68c472f3a904fc8fbefaa97ae26a
git remote add atishp04 https://github.com/atishp04/linux
git fetch --no-tags atishp04 isa_ext_support
git checkout ae97a995345b68c472f3a904fc8fbefaa97ae26a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/kernel/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> arch/riscv/kernel/cpufeature.c:82:24: warning: address of array 'edata->dtprop' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (!edata || !edata->dtprop)
~~~~~~~~^~~~~~
1 warning generated.
vim +82 arch/riscv/kernel/cpufeature.c
76
77 int riscv_isa_ext_list_add(struct riscv_isa_ext_data *edata)
78 {
79 struct device_node *node, *enode;
80 int eid;
81
> 82 if (!edata || !edata->dtprop)
83 return -EINVAL;
84
85 node = of_find_node_by_path("/cpus");
86 if (!node) {
87 pr_err("No CPU information found in DT\n");
88 return -ENOENT;
89 }
90
91 enode = of_get_child_by_name(node, "riscv,isa-ext");
92 if (!enode) {
93 pr_err("No riscv-isa-ext found in DT\n");
94 return -ENOENT;
95 }
96
97 eid = edata->isa_ext_id;
98 if (eid < RISCV_ISA_EXT_BASE || eid >= RISCV_ISA_EXT_MAX)
99 return -EINVAL;
100
101 if (!of_property_read_bool(enode, edata->dtprop)) {
102 pr_err("The ISA extension %s is not present in DT\n", edata->dtprop);
103 return -ENODEV;
104 }
105
106 /* Enable the extension id in the riscv_isa for easier probing */
107 riscv_isa[0] |= 1 << eid;
108 list_add(&edata->node, &riscv_isa_ext_list);
109 pr_info("RISC-V ISA extension '%s' available\n", edata->uprop);
110
111 return 0;
112 }
113
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [atishp04:isa_ext_support 3/4] arch/riscv/kernel/cpufeature.c:82:24: warning: address of array 'edata->dtprop' will always evaluate to 'true'
2021-12-27 19:19 [atishp04:isa_ext_support 3/4] arch/riscv/kernel/cpufeature.c:82:24: warning: address of array 'edata->dtprop' will always evaluate to 'true' kernel test robot
@ 2021-12-28 8:37 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-12-28 8:37 UTC (permalink / raw)
To: kernel test robot
Cc: Atish Patra, llvm, kbuild-all, Atish Patra, Linux Kernel Mailing List
On Tue, Dec 28, 2021 at 9:21 AM kernel test robot <lkp@intel.com> wrote:
> tree: https://github.com/atishp04/linux isa_ext_support
> head: cf2f3fa532aa7c672f681ca0685046c738bfb45f
> commit: ae97a995345b68c472f3a904fc8fbefaa97ae26a [3/4] RISC-V: Provide a framework for parsing multi-letter ISA extensions
> config: riscv-randconfig-c006-20211226 (https://download.01.org/0day-ci/archive/20211228/202112280309.fgjGevFd-lkp@intel.com/config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 0c553cc1af2e4c14100df6cf4a6fc91987e778e6)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install riscv cross compiling tool for clang build
> # apt-get install binutils-riscv64-linux-gnu
> # https://github.com/atishp04/linux/commit/ae97a995345b68c472f3a904fc8fbefaa97ae26a
> git remote add atishp04 https://github.com/atishp04/linux
> git fetch --no-tags atishp04 isa_ext_support
> git checkout ae97a995345b68c472f3a904fc8fbefaa97ae26a
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/kernel/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> arch/riscv/kernel/cpufeature.c:82:24: warning: address of array 'edata->dtprop' will always evaluate to 'true' [-Wpointer-bool-conversion]
> if (!edata || !edata->dtprop)
> ~~~~~~~~^~~~~~
> 1 warning generated.
>
>
> vim +82 arch/riscv/kernel/cpufeature.c
>
> 76
> 77 int riscv_isa_ext_list_add(struct riscv_isa_ext_data *edata)
> 78 {
> 79 struct device_node *node, *enode;
> 80 int eid;
> 81
> > 82 if (!edata || !edata->dtprop)
if (!edata || !edata->dtprop[0])
> 83 return -EINVAL;
> 84
> 85 node = of_find_node_by_path("/cpus");
> 86 if (!node) {
> 87 pr_err("No CPU information found in DT\n");
> 88 return -ENOENT;
> 89 }
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-28 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-27 19:19 [atishp04:isa_ext_support 3/4] arch/riscv/kernel/cpufeature.c:82:24: warning: address of array 'edata->dtprop' will always evaluate to 'true' kernel test robot
2021-12-28 8:37 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).