* [PATCH V3 1/8] sched: Remove unused TASK_SIZE_OF
2021-12-28 6:47 [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs guoren
@ 2021-12-28 6:47 ` guoren
2021-12-28 6:47 ` [PATCH V3 2/8] sched: x86: " guoren
` (7 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: guoren @ 2021-12-28 6:47 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli,
christophe.leroy, hca
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux, now. Delete in include/linux/sched.h
and arch's include/asm. This would confuse people who are
implementing the COMPAT feature for architecture.
Here is the comment by Arnd:
Looking through the git history, I see commit a06db751c321 ("pagemap:
check permissions and capabilities at open time") removing the last
user.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
---
include/linux/sched.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 78c351e35fec..8e5689d06ac8 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -2166,10 +2166,6 @@ static inline bool vcpu_is_preempted(int cpu)
extern long sched_setaffinity(pid_t pid, const struct cpumask *new_mask);
extern long sched_getaffinity(pid_t pid, struct cpumask *mask);
-#ifndef TASK_SIZE_OF
-#define TASK_SIZE_OF(tsk) TASK_SIZE
-#endif
-
#ifdef CONFIG_SMP
/* Returns effective CPU energy utilization, as seen by the scheduler */
unsigned long sched_cpu_util(int cpu, unsigned long max);
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH V3 2/8] sched: x86: Remove unused TASK_SIZE_OF
2021-12-28 6:47 [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs guoren
2021-12-28 6:47 ` [PATCH V3 1/8] sched: Remove unused TASK_SIZE_OF guoren
@ 2021-12-28 6:47 ` guoren
2021-12-28 6:47 ` [PATCH V3 3/8] sched: sparc: " guoren
` (6 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: guoren @ 2021-12-28 6:47 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli,
christophe.leroy, hca
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
---
arch/x86/include/asm/page_64_types.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/include/asm/page_64_types.h b/arch/x86/include/asm/page_64_types.h
index e9e2c3ba5923..6191cf417c31 100644
--- a/arch/x86/include/asm/page_64_types.h
+++ b/arch/x86/include/asm/page_64_types.h
@@ -74,8 +74,6 @@
IA32_PAGE_OFFSET : DEFAULT_MAP_WINDOW)
#define TASK_SIZE (test_thread_flag(TIF_ADDR32) ? \
IA32_PAGE_OFFSET : TASK_SIZE_MAX)
-#define TASK_SIZE_OF(child) ((test_tsk_thread_flag(child, TIF_ADDR32)) ? \
- IA32_PAGE_OFFSET : TASK_SIZE_MAX)
#define STACK_TOP TASK_SIZE_LOW
#define STACK_TOP_MAX TASK_SIZE_MAX
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH V3 3/8] sched: sparc: Remove unused TASK_SIZE_OF
2021-12-28 6:47 [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs guoren
2021-12-28 6:47 ` [PATCH V3 1/8] sched: Remove unused TASK_SIZE_OF guoren
2021-12-28 6:47 ` [PATCH V3 2/8] sched: x86: " guoren
@ 2021-12-28 6:47 ` guoren
2021-12-28 6:47 ` [PATCH V3 4/8] sched: powerpc: " guoren
` (5 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: guoren @ 2021-12-28 6:47 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli,
christophe.leroy, hca
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
---
arch/sparc/include/asm/processor_64.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/sparc/include/asm/processor_64.h b/arch/sparc/include/asm/processor_64.h
index ae851e8fce4c..628349fc4cdd 100644
--- a/arch/sparc/include/asm/processor_64.h
+++ b/arch/sparc/include/asm/processor_64.h
@@ -27,9 +27,6 @@
#define VPTE_SIZE (1 << (VA_BITS - PAGE_SHIFT + 3))
#endif
-#define TASK_SIZE_OF(tsk) \
- (test_tsk_thread_flag(tsk,TIF_32BIT) ? \
- (1UL << 32UL) : ((unsigned long)-VPTE_SIZE))
#define TASK_SIZE \
(test_thread_flag(TIF_32BIT) ? \
(1UL << 32UL) : ((unsigned long)-VPTE_SIZE))
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH V3 4/8] sched: powerpc: Remove unused TASK_SIZE_OF
2021-12-28 6:47 [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs guoren
` (2 preceding siblings ...)
2021-12-28 6:47 ` [PATCH V3 3/8] sched: sparc: " guoren
@ 2021-12-28 6:47 ` guoren
2021-12-28 6:47 ` [PATCH V3 5/8] sched: s390: " guoren
` (4 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: guoren @ 2021-12-28 6:47 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli,
christophe.leroy, hca
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux sched, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
---
arch/powerpc/include/asm/task_size_64.h | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/powerpc/include/asm/task_size_64.h b/arch/powerpc/include/asm/task_size_64.h
index c993482237ed..38fdf8041d12 100644
--- a/arch/powerpc/include/asm/task_size_64.h
+++ b/arch/powerpc/include/asm/task_size_64.h
@@ -44,11 +44,7 @@
*/
#define TASK_SIZE_USER32 (0x0000000100000000UL - (1 * PAGE_SIZE))
-#define TASK_SIZE_OF(tsk) \
- (test_tsk_thread_flag(tsk, TIF_32BIT) ? TASK_SIZE_USER32 : \
- TASK_SIZE_USER64)
-
-#define TASK_SIZE TASK_SIZE_OF(current)
+#define TASK_SIZE (is_32bit_task() ? TASK_SIZE_USER32 : TASK_SIZE_USER64)
#define TASK_UNMAPPED_BASE_USER32 (PAGE_ALIGN(TASK_SIZE_USER32 / 4))
#define TASK_UNMAPPED_BASE_USER64 (PAGE_ALIGN(DEFAULT_MAP_WINDOW_USER64 / 4))
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH V3 5/8] sched: s390: Remove unused TASK_SIZE_OF
2021-12-28 6:47 [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs guoren
` (3 preceding siblings ...)
2021-12-28 6:47 ` [PATCH V3 4/8] sched: powerpc: " guoren
@ 2021-12-28 6:47 ` guoren
2021-12-28 17:00 ` Heiko Carstens
2021-12-28 6:47 ` [PATCH V3 6/8] sched: parisc: " guoren
` (3 subsequent siblings)
8 siblings, 1 reply; 11+ messages in thread
From: guoren @ 2021-12-28 6:47 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli,
christophe.leroy, hca
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux sched, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
---
arch/s390/include/asm/processor.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/s390/include/asm/processor.h b/arch/s390/include/asm/processor.h
index f54c152bf2bf..5581b64a4236 100644
--- a/arch/s390/include/asm/processor.h
+++ b/arch/s390/include/asm/processor.h
@@ -88,11 +88,10 @@ extern void __bpon(void);
* User space process size: 2GB for 31 bit, 4TB or 8PT for 64 bit.
*/
-#define TASK_SIZE_OF(tsk) (test_tsk_thread_flag(tsk, TIF_31BIT) ? \
+#define TASK_SIZE (test_thread_flag(TIF_31BIT) ? \
_REGION3_SIZE : TASK_SIZE_MAX)
#define TASK_UNMAPPED_BASE (test_thread_flag(TIF_31BIT) ? \
(_REGION3_SIZE >> 1) : (_REGION2_SIZE >> 1))
-#define TASK_SIZE TASK_SIZE_OF(current)
#define TASK_SIZE_MAX (-PAGE_SIZE)
#define STACK_TOP (test_thread_flag(TIF_31BIT) ? \
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH V3 5/8] sched: s390: Remove unused TASK_SIZE_OF
2021-12-28 6:47 ` [PATCH V3 5/8] sched: s390: " guoren
@ 2021-12-28 17:00 ` Heiko Carstens
0 siblings, 0 replies; 11+ messages in thread
From: Heiko Carstens @ 2021-12-28 17:00 UTC (permalink / raw)
To: guoren
Cc: will, tglx, benh, arnd, mingo, peterz, juri.lelli,
christophe.leroy, linux-kernel, linux-riscv, linux-s390,
sparclinux, linuxppc-dev, inux-parisc, linux-mips,
linux-arm-kernel, x86, Guo Ren
On Tue, Dec 28, 2021 at 02:47:26PM +0800, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> This macro isn't used in Linux sched, now. Delete in
> include/linux/sched.h and arch's include/asm.
>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/s390/include/asm/processor.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks!
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH V3 6/8] sched: parisc: Remove unused TASK_SIZE_OF
2021-12-28 6:47 [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs guoren
` (4 preceding siblings ...)
2021-12-28 6:47 ` [PATCH V3 5/8] sched: s390: " guoren
@ 2021-12-28 6:47 ` guoren
2021-12-28 6:47 ` [PATCH V3 7/8] sched: arm64: " guoren
` (2 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: guoren @ 2021-12-28 6:47 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli,
christophe.leroy, hca
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux sched, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
---
arch/parisc/include/asm/processor.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/parisc/include/asm/processor.h b/arch/parisc/include/asm/processor.h
index b669f4b9040b..d9c8dc76ee6a 100644
--- a/arch/parisc/include/asm/processor.h
+++ b/arch/parisc/include/asm/processor.h
@@ -23,8 +23,7 @@
#define HAVE_ARCH_PICK_MMAP_LAYOUT
-#define TASK_SIZE_OF(tsk) ((tsk)->thread.task_size)
-#define TASK_SIZE TASK_SIZE_OF(current)
+#define TASK_SIZE (current->thread.task_size)
#define TASK_UNMAPPED_BASE (current->thread.map_base)
#define DEFAULT_TASK_SIZE32 (0xFFF00000UL)
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH V3 7/8] sched: arm64: Remove unused TASK_SIZE_OF
2021-12-28 6:47 [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs guoren
` (5 preceding siblings ...)
2021-12-28 6:47 ` [PATCH V3 6/8] sched: parisc: " guoren
@ 2021-12-28 6:47 ` guoren
2021-12-28 6:47 ` [PATCH V3 8/8] sched: mips: " guoren
2022-01-10 1:50 ` (subset) [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs Michael Ellerman
8 siblings, 0 replies; 11+ messages in thread
From: guoren @ 2021-12-28 6:47 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli,
christophe.leroy, hca
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux sched, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm64/include/asm/processor.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h
index 6f41b65f9962..d24dfb49237d 100644
--- a/arch/arm64/include/asm/processor.h
+++ b/arch/arm64/include/asm/processor.h
@@ -65,8 +65,6 @@
#endif /* CONFIG_ARM64_64K_PAGES */
#define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \
TASK_SIZE_32 : TASK_SIZE_64)
-#define TASK_SIZE_OF(tsk) (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
- TASK_SIZE_32 : TASK_SIZE_64)
#define DEFAULT_MAP_WINDOW (test_thread_flag(TIF_32BIT) ? \
TASK_SIZE_32 : DEFAULT_MAP_WINDOW_64)
#else
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH V3 8/8] sched: mips: Remove unused TASK_SIZE_OF
2021-12-28 6:47 [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs guoren
` (6 preceding siblings ...)
2021-12-28 6:47 ` [PATCH V3 7/8] sched: arm64: " guoren
@ 2021-12-28 6:47 ` guoren
2022-01-10 1:50 ` (subset) [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs Michael Ellerman
8 siblings, 0 replies; 11+ messages in thread
From: guoren @ 2021-12-28 6:47 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli,
christophe.leroy, hca
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux sched, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
---
arch/mips/include/asm/processor.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/mips/include/asm/processor.h b/arch/mips/include/asm/processor.h
index 4bb24579d12e..8871fc5b0baa 100644
--- a/arch/mips/include/asm/processor.h
+++ b/arch/mips/include/asm/processor.h
@@ -61,9 +61,6 @@ extern int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src
#define TASK_SIZE (test_thread_flag(TIF_32BIT_ADDR) ? TASK_SIZE32 : TASK_SIZE64)
#define STACK_TOP_MAX TASK_SIZE64
-#define TASK_SIZE_OF(tsk) \
- (test_tsk_thread_flag(tsk, TIF_32BIT_ADDR) ? TASK_SIZE32 : TASK_SIZE64)
-
#define TASK_IS_32BIT_ADDR test_thread_flag(TIF_32BIT_ADDR)
#endif
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: (subset) [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs
2021-12-28 6:47 [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs guoren
` (7 preceding siblings ...)
2021-12-28 6:47 ` [PATCH V3 8/8] sched: mips: " guoren
@ 2022-01-10 1:50 ` Michael Ellerman
8 siblings, 0 replies; 11+ messages in thread
From: Michael Ellerman @ 2022-01-10 1:50 UTC (permalink / raw)
To: Guo Ren, linux-kernel, linuxppc-dev
On Tue, 28 Dec 2021 14:47:21 +0800, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> This macro isn't used in Linux, now. Delete in include/linux/sched.h
> and arch's include/asm. This would confuse people who are
> implementing the COMPAT feature for architecture.
>
> Changes in v3:
> - Fixup Documentation/process/submitting-patches.rst, add sender
> Signed-off-by.
>
> [...]
Applied to powerpc/next.
[4/8] sched: powerpc: Remove unused TASK_SIZE_OF
https://git.kernel.org/powerpc/c/08035a67f35a8765cac39bb12e56c61ee880227a
cheers
^ permalink raw reply [flat|nested] 11+ messages in thread