* [PATCH] can: gs_usb: Zero-initialize flags
@ 2022-01-06 0:29 Brian Silverman
2022-01-08 22:29 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Brian Silverman @ 2022-01-06 0:29 UTC (permalink / raw)
Cc: Brian Silverman, Brian Silverman, Wolfgang Grandegger,
Marc Kleine-Budde, David S. Miller, Jakub Kicinski,
Vincent Mailhol, open list:CAN NETWORK DRIVERS,
open list:NETWORKING DRIVERS, open list
No information is deliberately sent here in host->device communications,
but the open-source candleLight firmware echoes it back, which can
result in the GS_CAN_FLAG_OVERFLOW flag being set and generating
spurious ERRORFRAMEs.
Signed-off-by: Brian Silverman <brian.silverman@bluerivertech.com>
---
drivers/net/can/usb/gs_usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index 1b400de00f51..cc4ad8d59bd7 100644
--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -507,6 +507,7 @@ static netdev_tx_t gs_can_start_xmit(struct sk_buff *skb,
hf->echo_id = idx;
hf->channel = dev->channel;
+ hf->flags = 0;
cf = (struct can_frame *)skb->data;
base-commit: d2f38a3c6507b2520101f9a3807ed98f1bdc545a
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] can: gs_usb: Zero-initialize flags
2022-01-06 0:29 [PATCH] can: gs_usb: Zero-initialize flags Brian Silverman
@ 2022-01-08 22:29 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2022-01-08 22:29 UTC (permalink / raw)
To: Brian Silverman
Cc: Brian Silverman, Wolfgang Grandegger, David S. Miller,
Jakub Kicinski, Vincent Mailhol, open list:CAN NETWORK DRIVERS,
open list:NETWORKING DRIVERS, open list
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
On 05.01.2022 16:29:50, Brian Silverman wrote:
> No information is deliberately sent here in host->device communications,
> but the open-source candleLight firmware echoes it back, which can
> result in the GS_CAN_FLAG_OVERFLOW flag being set and generating
> spurious ERRORFRAMEs.
>
> Signed-off-by: Brian Silverman <brian.silverman@bluerivertech.com>
Applied to linux-can/testing + opened an issue on github:
https://github.com/candle-usb/candleLight_fw/issues/87
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-08 22:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-06 0:29 [PATCH] can: gs_usb: Zero-initialize flags Brian Silverman
2022-01-08 22:29 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).