linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: interrupt-controller: arm,gic-v3: Fix 'interrupts'
@ 2022-01-06 18:25 Rob Herring
  2022-01-06 19:18 ` Marc Zyngier
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2022-01-06 18:25 UTC (permalink / raw)
  To: Thomas Gleixner, Marc Zyngier; +Cc: Marc Zyngier, linux-kernel, devicetree

The 2nd example has an interrupts cells size of 4, but the 'interrupts'
property has 3 cells. The example should also be separate since the cell
size differs in each example.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/interrupt-controller/arm,gic-v3.yaml   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
index c84f9fe7f254..cfb3ec27bd2b 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
@@ -239,6 +239,7 @@ examples:
       };
     };
 
+  - |
     interrupt-controller@2c010000 {
       compatible = "arm,gic-v3";
       #interrupt-cells = <4>;
@@ -254,7 +255,7 @@ examples:
             <0x2c040000 0x2000>,  // GICC
             <0x2c060000 0x2000>,  // GICH
             <0x2c080000 0x2000>;  // GICV
-      interrupts = <1 9 4>;
+      interrupts = <1 9 4 0>;
 
       msi-controller@2c200000 {
         compatible = "arm,gic-v3-its";
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: interrupt-controller: arm,gic-v3: Fix 'interrupts'
  2022-01-06 18:25 [PATCH] dt-bindings: interrupt-controller: arm,gic-v3: Fix 'interrupts' Rob Herring
@ 2022-01-06 19:18 ` Marc Zyngier
  0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2022-01-06 19:18 UTC (permalink / raw)
  To: Rob Herring; +Cc: Thomas Gleixner, Marc Zyngier, linux-kernel, devicetree

On Thu, 06 Jan 2022 18:25:13 +0000,
Rob Herring <robh@kernel.org> wrote:
> 
> The 2nd example has an interrupts cells size of 4, but the 'interrupts'
> property has 3 cells. The example should also be separate since the cell
> size differs in each example.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-06 19:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-06 18:25 [PATCH] dt-bindings: interrupt-controller: arm,gic-v3: Fix 'interrupts' Rob Herring
2022-01-06 19:18 ` Marc Zyngier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).