Re: [PATCH] tcp: tcp_send_challenge_ack delete useless param `skb`

Re: [PATCH] tcp: tcp_send_challenge_ack delete useless param `skb`

[Eric Dumazet]

On Wed, Jan 5, 2022 at 4:33 PM Benjamin.Yim <yan2228598786@gmail.com> wrote:
>
> From: Benjamin <yan2228598786@gmail.com>
>
> After this parameter is passed in, there is no usage, and deleting it will
>  not bring any impact.
>
> Signed-off-by: Benjamin <yan2228598786@gmail.com>

SGTM, thanks !
Reviewed-by: Eric Dumazet <edumazet@google.com>

Re: [PATCH] tcp: tcp_send_challenge_ack delete useless param `skb`

[Jakub Kicinski]

On Thu,  6 Jan 2022 08:32:45 +0800 Benjamin.Yim yan2228598786@gmail.com
wrote:
> From: Benjamin <yan2228598786@gmail.com>
> 
> After this parameter is passed in, there is no usage, and deleting it will
>  not bring any impact.
> 
> Signed-off-by: Benjamin <yan2228598786@gmail.com>

This one did not make it to patchwork or lore.

Please resend. Perhaps the reason was the odd looking From header:

From: Benjamin.Yim yan2228598786@gmail.com

Maybe it should have <> brackets? Please also use your full name for
the patch author and sign-off - should you be "Benjamin Yim"?

Re: [PATCH] tcp: tcp_send_challenge_ack delete useless param `skb`

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Sun,  9 Jan 2022 21:08:24 +0800 you wrote:
> After this parameter is passed in, there is no usage, and deleting it will
>  not bring any impact.
> 
> Signed-off-by: Benjamin Yim <yan2228598786@gmail.com>
> ---
>  net/ipv4/tcp_input.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Here is the summary with links:
  - tcp: tcp_send_challenge_ack delete useless param `skb`
    https://git.kernel.org/netdev/net-next/c/208dd45d8d05

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

[PATCH] tcp: tcp_send_challenge_ack delete useless param `skb`

[Benjamin Yim]

After this parameter is passed in, there is no usage, and deleting it will
 not bring any impact.

Signed-off-by: Benjamin Yim <yan2228598786@gmail.com>
---
 net/ipv4/tcp_input.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 8010583f868b..dc49a3d551eb 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -3601,7 +3601,7 @@ bool tcp_oow_rate_limited(struct net *net, const struct sk_buff *skb,
 }
 
 /* RFC 5961 7 [ACK Throttling] */
-static void tcp_send_challenge_ack(struct sock *sk, const struct sk_buff *skb)
+static void tcp_send_challenge_ack(struct sock *sk)
 {
 	/* unprotected vars, we dont care of overwrites */
 	static u32 challenge_timestamp;
@@ -3763,7 +3763,7 @@ static int tcp_ack(struct sock *sk, const struct sk_buff *skb, int flag)
 		/* RFC 5961 5.2 [Blind Data Injection Attack].[Mitigation] */
 		if (before(ack, prior_snd_una - tp->max_window)) {
 			if (!(flag & FLAG_NO_CHALLENGE_ACK))
-				tcp_send_challenge_ack(sk, skb);
+				tcp_send_challenge_ack(sk);
 			return -1;
 		}
 		goto old_ack;
@@ -5726,7 +5726,7 @@ static bool tcp_validate_incoming(struct sock *sk, struct sk_buff *skb,
 			if (tp->syn_fastopen && !tp->data_segs_in &&
 			    sk->sk_state == TCP_ESTABLISHED)
 				tcp_fastopen_active_disable(sk);
-			tcp_send_challenge_ack(sk, skb);
+			tcp_send_challenge_ack(sk);
 		}
 		goto discard;
 	}
@@ -5741,7 +5741,7 @@ static bool tcp_validate_incoming(struct sock *sk, struct sk_buff *skb,
 		if (syn_inerr)
 			TCP_INC_STATS(sock_net(sk), TCP_MIB_INERRS);
 		NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPSYNCHALLENGE);
-		tcp_send_challenge_ack(sk, skb);
+		tcp_send_challenge_ack(sk);
 		goto discard;
 	}
 
@@ -6456,7 +6456,7 @@ int tcp_rcv_state_process(struct sock *sk, struct sk_buff *skb)
 	if (!acceptable) {
 		if (sk->sk_state == TCP_SYN_RECV)
 			return 1;	/* send one RST */
-		tcp_send_challenge_ack(sk, skb);
+		tcp_send_challenge_ack(sk);
 		goto discard;
 	}
 	switch (sk->sk_state) {
-- 
2.33.1