* [PATCH] softingcs: Fix memleak on registration failure in softingcs_probe
@ 2022-01-08 9:25 Miaoqian Lin
2022-01-08 21:47 ` Marc Kleine-Budde
2022-01-09 22:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Miaoqian Lin @ 2022-01-08 9:25 UTC (permalink / raw)
Cc: linmq006, Wolfgang Grandegger, Marc Kleine-Budde,
David S. Miller, Jakub Kicinski, Kurt Van Dijck, linux-can,
netdev, linux-kernel
In case device registration fails during module initialisation, the
platform device structure needs to be freed using platform_device_put()
to properly free all resources (e.g. the device name).
Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/net/can/softing/softing_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/softing/softing_cs.c b/drivers/net/can/softing/softing_cs.c
index 2e93ee792373..e5c939b63fa6 100644
--- a/drivers/net/can/softing/softing_cs.c
+++ b/drivers/net/can/softing/softing_cs.c
@@ -293,7 +293,7 @@ static int softingcs_probe(struct pcmcia_device *pcmcia)
return 0;
platform_failed:
- kfree(dev);
+ platform_device_put(pdev);
mem_failed:
pcmcia_bad:
pcmcia_failed:
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] softingcs: Fix memleak on registration failure in softingcs_probe
2022-01-08 9:25 [PATCH] softingcs: Fix memleak on registration failure in softingcs_probe Miaoqian Lin
@ 2022-01-08 21:47 ` Marc Kleine-Budde
2022-01-09 22:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2022-01-08 21:47 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Wolfgang Grandegger, David S. Miller, Jakub Kicinski,
Kurt Van Dijck, linux-can, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
On 08.01.2022 09:25:51, Miaoqian Lin wrote:
> In case device registration fails during module initialisation, the
> platform device structure needs to be freed using platform_device_put()
> to properly free all resources (e.g. the device name).
>
> Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Thanks for your patch, a similar one has already been posted:
| https://lore.kernel.org/all/20211222104843.6105-1-johan@kernel.org/
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] softingcs: Fix memleak on registration failure in softingcs_probe
2022-01-08 9:25 [PATCH] softingcs: Fix memleak on registration failure in softingcs_probe Miaoqian Lin
2022-01-08 21:47 ` Marc Kleine-Budde
@ 2022-01-09 22:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-01-09 22:10 UTC (permalink / raw)
To: Miaoqian Lin
Cc: wg, mkl, davem, kuba, dev.kurt, linux-can, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Marc Kleine-Budde <mkl@pengutronix.de>:
On Sat, 8 Jan 2022 09:25:51 +0000 you wrote:
> In case device registration fails during module initialisation, the
> platform device structure needs to be freed using platform_device_put()
> to properly free all resources (e.g. the device name).
>
> Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>
> [...]
Here is the summary with links:
- softingcs: Fix memleak on registration failure in softingcs_probe
https://git.kernel.org/netdev/net/c/ced4913efb0a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-09 22:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-08 9:25 [PATCH] softingcs: Fix memleak on registration failure in softingcs_probe Miaoqian Lin
2022-01-08 21:47 ` Marc Kleine-Budde
2022-01-09 22:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).