From: Steven Rostedt <rostedt@goodmis.org>
To: Yuntao Wang <ytcoode@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: Remove duplicate warnings
Date: Sun, 9 Jan 2022 10:16:11 -0500 [thread overview]
Message-ID: <20220109101611.73da76d9@rorschach.local.home> (raw)
In-Reply-To: <20220109134858.306061-1-ytcoode@gmail.com>
On Sun, 9 Jan 2022 21:48:58 +0800
Yuntao Wang <ytcoode@gmail.com> wrote:
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 92be9cb1d7d4..d7da46df16c5 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -3462,7 +3462,6 @@ create_event_toplevel_files(struct dentry *parent, struct trace_array *tr)
> entry = trace_create_file("enable", TRACE_MODE_WRITE, d_events,
> tr, &ftrace_tr_enable_fops);
> if (!entry) {
> - pr_warn("Could not create tracefs 'enable' entry\n");
> return -ENOMEM;
> }
If it is becoming a simple condition then you don't need the braces.
if (!entry)
return -ENOMEM;
-- Steve
next prev parent reply other threads:[~2022-01-09 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 13:48 [PATCH] tracing: Remove duplicate warnings Yuntao Wang
2022-01-09 15:16 ` Steven Rostedt [this message]
2022-01-09 16:22 ` [PATCH v2] " Yuntao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220109101611.73da76d9@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ytcoode@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).