* [PATCH] tracing: Remove duplicate warnings
@ 2022-01-09 13:48 Yuntao Wang
2022-01-09 15:16 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Yuntao Wang @ 2022-01-09 13:48 UTC (permalink / raw)
To: Steven Rostedt, Ingo Molnar; +Cc: linux-kernel, Yuntao Wang
Since the same warning message is already printed in the
trace_create_file() function, there is no need to print it again.
Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
---
kernel/trace/trace_events.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 92be9cb1d7d4..d7da46df16c5 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -3462,7 +3462,6 @@ create_event_toplevel_files(struct dentry *parent, struct trace_array *tr)
entry = trace_create_file("enable", TRACE_MODE_WRITE, d_events,
tr, &ftrace_tr_enable_fops);
if (!entry) {
- pr_warn("Could not create tracefs 'enable' entry\n");
return -ENOMEM;
}
@@ -3480,17 +3479,13 @@ create_event_toplevel_files(struct dentry *parent, struct trace_array *tr)
pr_warn("Could not create tracefs 'set_event_notrace_pid' entry\n");
/* ring buffer internal formats */
- entry = trace_create_file("header_page", TRACE_MODE_READ, d_events,
+ trace_create_file("header_page", TRACE_MODE_READ, d_events,
ring_buffer_print_page_header,
&ftrace_show_header_fops);
- if (!entry)
- pr_warn("Could not create tracefs 'header_page' entry\n");
- entry = trace_create_file("header_event", TRACE_MODE_READ, d_events,
+ trace_create_file("header_event", TRACE_MODE_READ, d_events,
ring_buffer_print_entry_header,
&ftrace_show_header_fops);
- if (!entry)
- pr_warn("Could not create tracefs 'header_event' entry\n");
tr->event_dir = d_events;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing: Remove duplicate warnings
2022-01-09 13:48 [PATCH] tracing: Remove duplicate warnings Yuntao Wang
@ 2022-01-09 15:16 ` Steven Rostedt
2022-01-09 16:22 ` [PATCH v2] " Yuntao Wang
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2022-01-09 15:16 UTC (permalink / raw)
To: Yuntao Wang; +Cc: Ingo Molnar, linux-kernel
On Sun, 9 Jan 2022 21:48:58 +0800
Yuntao Wang <ytcoode@gmail.com> wrote:
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 92be9cb1d7d4..d7da46df16c5 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -3462,7 +3462,6 @@ create_event_toplevel_files(struct dentry *parent, struct trace_array *tr)
> entry = trace_create_file("enable", TRACE_MODE_WRITE, d_events,
> tr, &ftrace_tr_enable_fops);
> if (!entry) {
> - pr_warn("Could not create tracefs 'enable' entry\n");
> return -ENOMEM;
> }
If it is becoming a simple condition then you don't need the braces.
if (!entry)
return -ENOMEM;
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] tracing: Remove duplicate warnings
2022-01-09 15:16 ` Steven Rostedt
@ 2022-01-09 16:22 ` Yuntao Wang
0 siblings, 0 replies; 3+ messages in thread
From: Yuntao Wang @ 2022-01-09 16:22 UTC (permalink / raw)
To: Steven Rostedt, Ingo Molnar; +Cc: linux-kernel, Yuntao Wang
Since the same warning message is already printed in the
trace_create_file() function, there is no need to print it again.
Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
---
Changes since v1:
- remove unnecessary braces
kernel/trace/trace_events.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 92be9cb1d7d4..3147614c1812 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -3461,10 +3461,8 @@ create_event_toplevel_files(struct dentry *parent, struct trace_array *tr)
entry = trace_create_file("enable", TRACE_MODE_WRITE, d_events,
tr, &ftrace_tr_enable_fops);
- if (!entry) {
- pr_warn("Could not create tracefs 'enable' entry\n");
+ if (!entry)
return -ENOMEM;
- }
/* There are not as crucial, just warn if they are not created */
@@ -3480,17 +3478,13 @@ create_event_toplevel_files(struct dentry *parent, struct trace_array *tr)
pr_warn("Could not create tracefs 'set_event_notrace_pid' entry\n");
/* ring buffer internal formats */
- entry = trace_create_file("header_page", TRACE_MODE_READ, d_events,
+ trace_create_file("header_page", TRACE_MODE_READ, d_events,
ring_buffer_print_page_header,
&ftrace_show_header_fops);
- if (!entry)
- pr_warn("Could not create tracefs 'header_page' entry\n");
- entry = trace_create_file("header_event", TRACE_MODE_READ, d_events,
+ trace_create_file("header_event", TRACE_MODE_READ, d_events,
ring_buffer_print_entry_header,
&ftrace_show_header_fops);
- if (!entry)
- pr_warn("Could not create tracefs 'header_event' entry\n");
tr->event_dir = d_events;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-09 16:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-09 13:48 [PATCH] tracing: Remove duplicate warnings Yuntao Wang
2022-01-09 15:16 ` Steven Rostedt
2022-01-09 16:22 ` [PATCH v2] " Yuntao Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).