* [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes
@ 2022-01-07 3:20 Rob Herring
2022-01-07 15:01 ` Sa, Nuno
2022-01-10 1:09 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Rob Herring @ 2022-01-07 3:20 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Nuno Sá, Jonathan Cameron
Cc: linux-iio, devicetree, linux-kernel
The '/bits/ 64' notation applies the next <> list of values. Another <> list
is encoded as 32-bits by default. IOW, each <> list needs to be preceeded
with '/bits/ 64'.
While the dts format allows this, as a rule we don't mix sizes for DT
properties since all size information is lost in the dtb file.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/iio/temperature/adi,ltc2983.yaml | 22 +++++++++----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
index 0f79d9a01c49..722781aa4697 100644
--- a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
+++ b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
@@ -448,17 +448,17 @@ examples:
reg = <20>;
adi,sensor-type = <9>; //custom thermocouple
adi,single-ended;
- adi,custom-thermocouple = /bits/ 64
- <(-50220000) 0>,
- <(-30200000) 99100000>,
- <(-5300000) 135400000>,
- <0 273150000>,
- <40200000 361200000>,
- <55300000 522100000>,
- <88300000 720300000>,
- <132200000 811200000>,
- <188700000 922500000>,
- <460400000 1000000000>; //10 pairs
+ adi,custom-thermocouple =
+ /bits/ 64 <(-50220000) 0>,
+ /bits/ 64 <(-30200000) 99100000>,
+ /bits/ 64 <(-5300000) 135400000>,
+ /bits/ 64 <0 273150000>,
+ /bits/ 64 <40200000 361200000>,
+ /bits/ 64 <55300000 522100000>,
+ /bits/ 64 <88300000 720300000>,
+ /bits/ 64 <132200000 811200000>,
+ /bits/ 64 <188700000 922500000>,
+ /bits/ 64 <460400000 1000000000>; //10 pairs
};
};
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes
2022-01-07 3:20 [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes Rob Herring
@ 2022-01-07 15:01 ` Sa, Nuno
2022-01-09 15:13 ` Jonathan Cameron
2022-01-10 1:09 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Sa, Nuno @ 2022-01-07 15:01 UTC (permalink / raw)
To: Rob Herring, Lars-Peter Clausen, Hennerich, Michael, Jonathan Cameron
Cc: linux-iio, devicetree, linux-kernel
> From: Rob Herring <robh@kernel.org>
> Sent: Friday, January 7, 2022 4:20 AM
> To: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael
> <Michael.Hennerich@analog.com>; Sa, Nuno
> <Nuno.Sa@analog.com>; Jonathan Cameron <jic23@kernel.org>
> Cc: linux-iio@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes
>
> [External]
>
> The '/bits/ 64' notation applies the next <> list of values. Another <>
> list
> is encoded as 32-bits by default. IOW, each <> list needs to be
> preceeded
> with '/bits/ 64'.
>
> While the dts format allows this, as a rule we don't mix sizes for DT
> properties since all size information is lost in the dtb file.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Thanks!
- Nuno Sá
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes
2022-01-07 15:01 ` Sa, Nuno
@ 2022-01-09 15:13 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2022-01-09 15:13 UTC (permalink / raw)
To: Sa, Nuno
Cc: Rob Herring, Lars-Peter Clausen, Hennerich, Michael, linux-iio,
devicetree, linux-kernel
On Fri, 7 Jan 2022 15:01:29 +0000
"Sa, Nuno" <Nuno.Sa@analog.com> wrote:
> > From: Rob Herring <robh@kernel.org>
> > Sent: Friday, January 7, 2022 4:20 AM
> > To: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael
> > <Michael.Hennerich@analog.com>; Sa, Nuno
> > <Nuno.Sa@analog.com>; Jonathan Cameron <jic23@kernel.org>
> > Cc: linux-iio@vger.kernel.org; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes
> >
> > [External]
> >
> > The '/bits/ 64' notation applies the next <> list of values. Another <>
> > list
> > is encoded as 32-bits by default. IOW, each <> list needs to be
> > preceeded
> > with '/bits/ 64'.
> >
> > While the dts format allows this, as a rule we don't mix sizes for DT
> > properties since all size information is lost in the dtb file.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Hi Rob,
Do you want me to pick these up, or as they are fixes would you rather take
them yourself to get them in quickly?
In case you want to pick this up.
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Thanks!
> - Nuno Sá
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes
2022-01-07 3:20 [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes Rob Herring
2022-01-07 15:01 ` Sa, Nuno
@ 2022-01-10 1:09 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-01-10 1:09 UTC (permalink / raw)
To: Rob Herring
Cc: Lars-Peter Clausen, Jonathan Cameron, linux-kernel, linux-iio,
Michael Hennerich, devicetree, Nuno Sá
On Thu, 06 Jan 2022 21:20:26 -0600, Rob Herring wrote:
> The '/bits/ 64' notation applies the next <> list of values. Another <> list
> is encoded as 32-bits by default. IOW, each <> list needs to be preceeded
> with '/bits/ 64'.
>
> While the dts format allows this, as a rule we don't mix sizes for DT
> properties since all size information is lost in the dtb file.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/iio/temperature/adi,ltc2983.yaml | 22 +++++++++----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-10 1:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-07 3:20 [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes Rob Herring
2022-01-07 15:01 ` Sa, Nuno
2022-01-09 15:13 ` Jonathan Cameron
2022-01-10 1:09 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).