* [PATCH] dt-bindings: iio/adc: ti,palmas-gpadc: Split interrupt fields in example
@ 2022-01-06 18:25 Rob Herring
2022-01-09 15:15 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2022-01-06 18:25 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen, Tony Lindgren
Cc: linux-iio, devicetree, linux-kernel
Best practice for multi-cell property values is to bracket each multi-cell
value.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
index 7b895784e008..57a31356082e 100644
--- a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
@@ -74,9 +74,9 @@ examples:
compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
adc {
compatible = "ti,palmas-gpadc";
- interrupts = <18 0
- 16 0
- 17 0>;
+ interrupts = <18 0>,
+ <16 0>,
+ <17 0>;
#io-channel-cells = <1>;
ti,channel0-current-microamp = <5>;
ti,channel3-current-microamp = <10>;
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: iio/adc: ti,palmas-gpadc: Split interrupt fields in example
2022-01-06 18:25 [PATCH] dt-bindings: iio/adc: ti,palmas-gpadc: Split interrupt fields in example Rob Herring
@ 2022-01-09 15:15 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-01-09 15:15 UTC (permalink / raw)
To: Rob Herring
Cc: Lars-Peter Clausen, Tony Lindgren, linux-iio, devicetree, linux-kernel
On Thu, 6 Jan 2022 12:25:11 -0600
Rob Herring <robh@kernel.org> wrote:
> Best practice for multi-cell property values is to bracket each multi-cell
> value.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied to the togreg branch of iio.git.
I'm assuming there is no rush on this as it's best practice rather than a bug.
Thanks,
Jonathan
> ---
> .../devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
> index 7b895784e008..57a31356082e 100644
> --- a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
> @@ -74,9 +74,9 @@ examples:
> compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
> adc {
> compatible = "ti,palmas-gpadc";
> - interrupts = <18 0
> - 16 0
> - 17 0>;
> + interrupts = <18 0>,
> + <16 0>,
> + <17 0>;
> #io-channel-cells = <1>;
> ti,channel0-current-microamp = <5>;
> ti,channel3-current-microamp = <10>;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-09 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-06 18:25 [PATCH] dt-bindings: iio/adc: ti,palmas-gpadc: Split interrupt fields in example Rob Herring
2022-01-09 15:15 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).