From: Pratyush Yadav <p.yadav@ti.com>
To: Dhananjay Phadke <dphadke@linux.microsoft.com>
Cc: Michael Walle <michael@walle.cc>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: Add support for w25q512jvm
Date: Tue, 11 Jan 2022 11:21:09 +0530 [thread overview]
Message-ID: <20220111055107.tevqpnt32mzjodok@ti.com> (raw)
In-Reply-To: <57513f5f-1e66-3758-a56b-1eced486a4df@linux.microsoft.com>
On 10/01/22 03:12PM, Dhananjay Phadke wrote:
> On 1/10/2022 7:10 AM, Michael Walle wrote:
> >
> > > + { "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024),
> >
> > OTP_INFO(256, 3, 0x1000, 0x1000)
> >
> > should enable OTP support, could you please test this using the
> > flash_otp_{dump,info,erase,write} tools and add that line?
>
> The board I've has HW filter between controller and NOR and doesn't seem to
> allow security reg access opcodes (read to be specific).
>
> So long as adding this doesn't affect probe, I can add it. Otherwise, will
> have to leave it for later when that's fixed.
Please don't it if you can't test it. In that case let's just leave it
for someone else to add later.
>
>
> On 1/9/2022 9:07 PM, Pratyush Yadav wrote:
> >
> > You need to show the dumps of the SFDP and other flash parameters. See
> > [0] for an example.
> >
> > The patch looks fine to me otherwise.
> >
>
> Lemme collect SFDP dump and include it in v2.
> I ended up sending stale patch that has extra comma between INFO()
> PARSE_SFDP macros, so need to re-spin anyway.
>
> Thanks,
> Dhananjay
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
prev parent reply other threads:[~2022-01-11 5:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 4:44 [PATCH] mtd: spi-nor: Add support for w25q512jvm Dhananjay Phadke
2022-01-10 5:07 ` Pratyush Yadav
2022-01-10 15:10 ` Michael Walle
2022-01-10 23:12 ` Dhananjay Phadke
2022-01-11 5:51 ` Pratyush Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111055107.tevqpnt32mzjodok@ti.com \
--to=p.yadav@ti.com \
--cc=dphadke@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).