From: Dhananjay Phadke <dphadke@linux.microsoft.com>
To: Michael Walle <michael@walle.cc>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: Add support for w25q512jvm
Date: Mon, 10 Jan 2022 15:12:49 -0800 [thread overview]
Message-ID: <57513f5f-1e66-3758-a56b-1eced486a4df@linux.microsoft.com> (raw)
In-Reply-To: <262a03e185c29583450180e3dc8c4e6c@walle.cc>
On 1/10/2022 7:10 AM, Michael Walle wrote:
>
>> + { "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024),
>
> OTP_INFO(256, 3, 0x1000, 0x1000)
>
> should enable OTP support, could you please test this using the
> flash_otp_{dump,info,erase,write} tools and add that line?
The board I've has HW filter between controller and NOR and doesn't seem
to allow security reg access opcodes (read to be specific).
So long as adding this doesn't affect probe, I can add it. Otherwise,
will have to leave it for later when that's fixed.
On 1/9/2022 9:07 PM, Pratyush Yadav wrote:
>
> You need to show the dumps of the SFDP and other flash parameters. See
> [0] for an example.
>
> The patch looks fine to me otherwise.
>
Lemme collect SFDP dump and include it in v2.
I ended up sending stale patch that has extra comma between INFO()
PARSE_SFDP macros, so need to re-spin anyway.
Thanks,
Dhananjay
next prev parent reply other threads:[~2022-01-10 23:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 4:44 [PATCH] mtd: spi-nor: Add support for w25q512jvm Dhananjay Phadke
2022-01-10 5:07 ` Pratyush Yadav
2022-01-10 15:10 ` Michael Walle
2022-01-10 23:12 ` Dhananjay Phadke [this message]
2022-01-11 5:51 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57513f5f-1e66-3758-a56b-1eced486a4df@linux.microsoft.com \
--to=dphadke@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).