* [PATCH] locking/rwsem: drop redundant semicolon of down_write_nest_lock
@ 2022-01-14 8:37 Guchun Chen
2022-01-14 8:40 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Guchun Chen @ 2022-01-14 8:37 UTC (permalink / raw)
To: peterz, mingo, will, longman, boqun.feng, linux-kernel
Cc: christian.koenig, Guchun Chen
Otherwise, braces are needed when using it.
Signed-off-by: Guchun Chen <guchun.chen@amd.com>
---
include/linux/rwsem.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
index f9348769e558..efa5c324369a 100644
--- a/include/linux/rwsem.h
+++ b/include/linux/rwsem.h
@@ -230,7 +230,7 @@ extern void _down_write_nest_lock(struct rw_semaphore *sem, struct lockdep_map *
do { \
typecheck(struct lockdep_map *, &(nest_lock)->dep_map); \
_down_write_nest_lock(sem, &(nest_lock)->dep_map); \
-} while (0);
+} while (0)
/*
* Take/release a lock when not the owner will release it.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] locking/rwsem: drop redundant semicolon of down_write_nest_lock
2022-01-14 8:37 [PATCH] locking/rwsem: drop redundant semicolon of down_write_nest_lock Guchun Chen
@ 2022-01-14 8:40 ` Christian König
2022-01-14 8:48 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2022-01-14 8:40 UTC (permalink / raw)
To: Guchun Chen, peterz, mingo, will, longman, boqun.feng,
linux-kernel, dri-devel
Am 14.01.22 um 09:37 schrieb Guchun Chen:
> Otherwise, braces are needed when using it.
>
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
Peter any objections that we push this upstream through the drm subsystem?
Thanks,
Christian.
> ---
> include/linux/rwsem.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
> index f9348769e558..efa5c324369a 100644
> --- a/include/linux/rwsem.h
> +++ b/include/linux/rwsem.h
> @@ -230,7 +230,7 @@ extern void _down_write_nest_lock(struct rw_semaphore *sem, struct lockdep_map *
> do { \
> typecheck(struct lockdep_map *, &(nest_lock)->dep_map); \
> _down_write_nest_lock(sem, &(nest_lock)->dep_map); \
> -} while (0);
> +} while (0)
>
> /*
> * Take/release a lock when not the owner will release it.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] locking/rwsem: drop redundant semicolon of down_write_nest_lock
2022-01-14 8:40 ` Christian König
@ 2022-01-14 8:48 ` Peter Zijlstra
0 siblings, 0 replies; 3+ messages in thread
From: Peter Zijlstra @ 2022-01-14 8:48 UTC (permalink / raw)
To: Christian König
Cc: Guchun Chen, mingo, will, longman, boqun.feng, linux-kernel, dri-devel
On Fri, Jan 14, 2022 at 09:40:54AM +0100, Christian König wrote:
> Am 14.01.22 um 09:37 schrieb Guchun Chen:
> > Otherwise, braces are needed when using it.
> >
> > Signed-off-by: Guchun Chen <guchun.chen@amd.com>
>
> Acked-by: Christian König <christian.koenig@amd.com>
>
> Peter any objections that we push this upstream through the drm subsystem?
Nah, take it.
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-14 8:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14 8:37 [PATCH] locking/rwsem: drop redundant semicolon of down_write_nest_lock Guchun Chen
2022-01-14 8:40 ` Christian König
2022-01-14 8:48 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).