* [PATCH] amdgpu/amdgpu_psp: remove unneeded ret variable
@ 2022-01-18 7:57 cgel.zte
2022-01-18 20:31 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-01-18 7:57 UTC (permalink / raw)
To: alexander.deucher
Cc: christian.koenig, Xinhui.Pan, airlied, daniel, Hawking.Zhang,
john.clements, candice.li, lijo.lazar, lang.yu, Oak.Zeng,
jonathan.kim, amd-gfx, dri-devel, linux-kernel, Minghao Chi,
Zeal Robot, CGEL ZTE
From: Minghao Chi <chi.minghao@zte.com.cn>
Return value from amdgpu_bo_create_kernel() directly instead
of taking this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index dee17a0e1187..ac2b87f81ef9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -914,19 +914,15 @@ static void psp_prep_ta_load_cmd_buf(struct psp_gfx_cmd_resp *cmd,
static int psp_ta_init_shared_buf(struct psp_context *psp,
struct ta_mem_context *mem_ctx)
{
- int ret;
-
/*
* Allocate 16k memory aligned to 4k from Frame Buffer (local
* physical) for ta to host memory
*/
- ret = amdgpu_bo_create_kernel(psp->adev, mem_ctx->shared_mem_size,
+ return amdgpu_bo_create_kernel(psp->adev, mem_ctx->shared_mem_size,
PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM,
&mem_ctx->shared_bo,
&mem_ctx->shared_mc_addr,
&mem_ctx->shared_buf);
-
- return ret;
}
static void psp_ta_free_shared_buf(struct ta_mem_context *mem_ctx)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] amdgpu/amdgpu_psp: remove unneeded ret variable
2022-01-18 7:57 [PATCH] amdgpu/amdgpu_psp: remove unneeded ret variable cgel.zte
@ 2022-01-18 20:31 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2022-01-18 20:31 UTC (permalink / raw)
To: CGEL
Cc: Deucher, Alexander, Lazar, Lijo, Dave Airlie, Lang Yu, Oak Zeng,
xinhui pan, LKML, amd-gfx list, Zeal Robot, Minghao Chi, Kim,
Jonathan, Maling list - DRI developers, Li, Candice,
John Clements, Christian Koenig, Hawking Zhang
Applied. Thanks!
Alex
On Tue, Jan 18, 2022 at 2:57 AM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value from amdgpu_bo_create_kernel() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index dee17a0e1187..ac2b87f81ef9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -914,19 +914,15 @@ static void psp_prep_ta_load_cmd_buf(struct psp_gfx_cmd_resp *cmd,
> static int psp_ta_init_shared_buf(struct psp_context *psp,
> struct ta_mem_context *mem_ctx)
> {
> - int ret;
> -
> /*
> * Allocate 16k memory aligned to 4k from Frame Buffer (local
> * physical) for ta to host memory
> */
> - ret = amdgpu_bo_create_kernel(psp->adev, mem_ctx->shared_mem_size,
> + return amdgpu_bo_create_kernel(psp->adev, mem_ctx->shared_mem_size,
> PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM,
> &mem_ctx->shared_bo,
> &mem_ctx->shared_mc_addr,
> &mem_ctx->shared_buf);
> -
> - return ret;
> }
>
> static void psp_ta_free_shared_buf(struct ta_mem_context *mem_ctx)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-18 20:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-18 7:57 [PATCH] amdgpu/amdgpu_psp: remove unneeded ret variable cgel.zte
2022-01-18 20:31 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).