* [PATCH] firmware: dmi-sysfs: Fix memory leak in dmi_system_event_log
@ 2022-01-20 11:55 Miaoqian Lin
0 siblings, 0 replies; only message in thread
From: Miaoqian Lin @ 2022-01-20 11:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, Miaoqian Lin, Mike Waychison, linux-kernel
According to the doc of kobject_init_and_add():
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object.
Fix memory leak by calling kobject_put().
The callback function dmi_entry_free() in kobject_put()
will call kfree to handle the pointer.
Fixes: 925a1da7477f ("firmware: Break out system_event_log in dmi-sysfs")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/firmware/dmi-sysfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/dmi-sysfs.c b/drivers/firmware/dmi-sysfs.c
index 3a353776bd34..d764fa578d66 100644
--- a/drivers/firmware/dmi-sysfs.c
+++ b/drivers/firmware/dmi-sysfs.c
@@ -458,7 +458,7 @@ static int dmi_system_event_log(struct dmi_sysfs_entry *entry)
&entry->kobj,
"system_event_log");
if (ret)
- goto out_free;
+ goto out_put;
ret = sysfs_create_bin_file(entry->child, &dmi_sel_raw_attr);
if (ret)
@@ -468,8 +468,8 @@ static int dmi_system_event_log(struct dmi_sysfs_entry *entry)
out_del:
kobject_del(entry->child);
-out_free:
- kfree(entry->child);
+out_put:
+ kobject_put(entry->child);
return ret;
}
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-01-20 11:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-20 11:55 [PATCH] firmware: dmi-sysfs: Fix memory leak in dmi_system_event_log Miaoqian Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).