* [PATCH] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
@ 2022-01-20 22:42 Nícolas F. R. A. Prado
2022-01-21 11:46 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 3+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-01-20 22:42 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger, Robert Foss, Xin Ji
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
kernel, Nícolas F. R. A. Prado
mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
its DSI host. However, after fd0310b6fe7d ("drm/bridge: anx7625: add
MIPI DPI input feature"), a bus-type property started being required in
the endpoint node by the driver to indicate whether it is DSI or DPI.
Add the missing bus-type property and set it to 5
(V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
configured to DSI and the display pipeline can probe correctly.
While at it, also set the data-lanes property that was also introduced
in that same commit, so that we don't rely on the default value.
Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
index 8f7bf33f607d..e8f133dc96b9 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
@@ -171,6 +171,8 @@ port@0 {
anx7625_in: endpoint {
remote-endpoint = <&dsi_out>;
+ bus-type = <5>;
+ data-lanes = <0 1 2 3>;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
2022-01-20 22:42 [PATCH] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint Nícolas F. R. A. Prado
@ 2022-01-21 11:46 ` AngeloGioacchino Del Regno
2022-01-31 16:17 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-01-21 11:46 UTC (permalink / raw)
To: Nícolas F. R. A. Prado, Rob Herring, Matthias Brugger,
Robert Foss, Xin Ji
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, kernel
Il 20/01/22 23:42, Nícolas F. R. A. Prado ha scritto:
> mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
> its DSI host. However, after fd0310b6fe7d ("drm/bridge: anx7625: add
> MIPI DPI input feature"), a bus-type property started being required in
> the endpoint node by the driver to indicate whether it is DSI or DPI.
>
> Add the missing bus-type property and set it to 5
> (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
> configured to DSI and the display pipeline can probe correctly.
>
> While at it, also set the data-lanes property that was also introduced
> in that same commit, so that we don't rely on the default value.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> index 8f7bf33f607d..e8f133dc96b9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> @@ -171,6 +171,8 @@ port@0 {
>
> anx7625_in: endpoint {
> remote-endpoint = <&dsi_out>;
> + bus-type = <5>;
> + data-lanes = <0 1 2 3>;
> };
> };
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
2022-01-21 11:46 ` AngeloGioacchino Del Regno
@ 2022-01-31 16:17 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2022-01-31 16:17 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: Nícolas F. R. A. Prado, Rob Herring, Matthias Brugger,
Xin Ji, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, kernel
Hey,
On Fri, 21 Jan 2022 at 12:46, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 20/01/22 23:42, Nícolas F. R. A. Prado ha scritto:
> > mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
> > its DSI host. However, after fd0310b6fe7d ("drm/bridge: anx7625: add
> > MIPI DPI input feature"), a bus-type property started being required in
> > the endpoint node by the driver to indicate whether it is DSI or DPI.
> >
> > Add the missing bus-type property and set it to 5
> > (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
> > configured to DSI and the display pipeline can probe correctly.
> >
> > While at it, also set the data-lanes property that was also introduced
> > in that same commit, so that we don't rely on the default value.
> >
> > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> > index 8f7bf33f607d..e8f133dc96b9 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> > @@ -171,6 +171,8 @@ port@0 {
> >
> > anx7625_in: endpoint {
> > remote-endpoint = <&dsi_out>;
> > + bus-type = <5>;
> > + data-lanes = <0 1 2 3>;
> > };
> > };
> >
> >
This patch does not pass checkpatch --strict, please add the word
commit before the hash in the commit message to fix this.
Rob.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-31 16:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-20 22:42 [PATCH] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint Nícolas F. R. A. Prado
2022-01-21 11:46 ` AngeloGioacchino Del Regno
2022-01-31 16:17 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).