* [PATCH v1 0/2] arm64: dts: imx8mq: fix mipi_csi port numbering
@ 2022-01-21 9:33 Martin Kepplinger
2022-01-21 9:33 ` [PATCH v1 1/2] arm64: dts: imx8mq: fix mipi_csi bidirectional port numbers Martin Kepplinger
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Martin Kepplinger @ 2022-01-21 9:33 UTC (permalink / raw)
To: robh, shawnguo
Cc: kernel, linux-imx, devicetree, linux-arm-kernel, phone-devel,
linux-kernel, Martin Kepplinger
hi Shawn and all interested,
This is a fix for an embarrassing bug that slipped into commit
bcadd5f66c2a ("arm64: dts: imx8mq: add mipi csi phy and csi bridge descriptions")
and commit fed7603597fa ("arm64: dts: imx8mq-librem5: describe the selfie cam").
When preparing the imx8mq.dtsi description I only tested with port@1
being connected to the csi bridge, but what I sent said port@0.
I have this on my list for a while and want to sort this out now. I'm
sorry for the inconvenience. Until now imx8mq-librem5 is the only user
(maybe because of this :).
thank you,
martin
Martin Kepplinger (2):
arm64: dts: imx8mq: fix mipi_csi bidirectional port numbers
arm64: dts: imx8mq-librem5: fix mipi_csi1 port number to sensor
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 4 ++--
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/2] arm64: dts: imx8mq: fix mipi_csi bidirectional port numbers
2022-01-21 9:33 [PATCH v1 0/2] arm64: dts: imx8mq: fix mipi_csi port numbering Martin Kepplinger
@ 2022-01-21 9:33 ` Martin Kepplinger
2022-01-21 9:33 ` [PATCH v1 2/2] arm64: dts: imx8mq-librem5: fix mipi_csi1 port number to sensor Martin Kepplinger
2022-01-29 6:30 ` [PATCH v1 0/2] arm64: dts: imx8mq: fix mipi_csi port numbering Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Martin Kepplinger @ 2022-01-21 9:33 UTC (permalink / raw)
To: robh, shawnguo
Cc: kernel, linux-imx, devicetree, linux-arm-kernel, phone-devel,
linux-kernel, Martin Kepplinger
The port numbers for the imx8mq mipi csi controller are wrong and
the mipi driver can't find any media devices as port@1 is connected
to the CSI bridge, not port@0. And port@0 is connected to the
source - the sensor. Fix this.
Fixes: bcadd5f66c2a ("arm64: dts: imx8mq: add mipi csi phy and csi bridge descriptions")
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 2df2510d0118..bb68c94c2fc9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1151,8 +1151,8 @@ ports {
#address-cells = <1>;
#size-cells = <0>;
- port@0 {
- reg = <0>;
+ port@1 {
+ reg = <1>;
csi1_mipi_ep: endpoint {
remote-endpoint = <&csi1_ep>;
@@ -1203,8 +1203,8 @@ ports {
#address-cells = <1>;
#size-cells = <0>;
- port@0 {
- reg = <0>;
+ port@1 {
+ reg = <1>;
csi2_mipi_ep: endpoint {
remote-endpoint = <&csi2_ep>;
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1 2/2] arm64: dts: imx8mq-librem5: fix mipi_csi1 port number to sensor
2022-01-21 9:33 [PATCH v1 0/2] arm64: dts: imx8mq: fix mipi_csi port numbering Martin Kepplinger
2022-01-21 9:33 ` [PATCH v1 1/2] arm64: dts: imx8mq: fix mipi_csi bidirectional port numbers Martin Kepplinger
@ 2022-01-21 9:33 ` Martin Kepplinger
2022-01-29 6:30 ` [PATCH v1 0/2] arm64: dts: imx8mq: fix mipi_csi port numbering Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Martin Kepplinger @ 2022-01-21 9:33 UTC (permalink / raw)
To: robh, shawnguo
Cc: kernel, linux-imx, devicetree, linux-arm-kernel, phone-devel,
linux-kernel, Martin Kepplinger
Since the previous commit fixed a hardware description bug for imx8mq,
we need to fix up all DT users like this. The mipi_csi port@0
is connected to the sensor, not port@1.
Fixes: fed7603597fa ("arm64: dts: imx8mq-librem5: describe the selfie cam")
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index f3e3418f7edc..2d4a472af6a9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -1115,8 +1115,8 @@ &mipi_csi1 {
status = "okay";
ports {
- port@1 {
- reg = <1>;
+ port@0 {
+ reg = <0>;
mipi1_sensor_ep: endpoint {
remote-endpoint = <&camera1_ep>;
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 0/2] arm64: dts: imx8mq: fix mipi_csi port numbering
2022-01-21 9:33 [PATCH v1 0/2] arm64: dts: imx8mq: fix mipi_csi port numbering Martin Kepplinger
2022-01-21 9:33 ` [PATCH v1 1/2] arm64: dts: imx8mq: fix mipi_csi bidirectional port numbers Martin Kepplinger
2022-01-21 9:33 ` [PATCH v1 2/2] arm64: dts: imx8mq-librem5: fix mipi_csi1 port number to sensor Martin Kepplinger
@ 2022-01-29 6:30 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2022-01-29 6:30 UTC (permalink / raw)
To: Martin Kepplinger
Cc: robh, kernel, linux-imx, devicetree, linux-arm-kernel,
phone-devel, linux-kernel
On Fri, Jan 21, 2022 at 10:33:24AM +0100, Martin Kepplinger wrote:
> hi Shawn and all interested,
>
> This is a fix for an embarrassing bug that slipped into commit
> bcadd5f66c2a ("arm64: dts: imx8mq: add mipi csi phy and csi bridge descriptions")
> and commit fed7603597fa ("arm64: dts: imx8mq-librem5: describe the selfie cam").
>
> When preparing the imx8mq.dtsi description I only tested with port@1
> being connected to the csi bridge, but what I sent said port@0.
>
> I have this on my list for a while and want to sort this out now. I'm
> sorry for the inconvenience. Until now imx8mq-librem5 is the only user
> (maybe because of this :).
>
> thank you,
>
> martin
>
>
> Martin Kepplinger (2):
> arm64: dts: imx8mq: fix mipi_csi bidirectional port numbers
> arm64: dts: imx8mq-librem5: fix mipi_csi1 port number to sensor
Applied both, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-29 6:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-21 9:33 [PATCH v1 0/2] arm64: dts: imx8mq: fix mipi_csi port numbering Martin Kepplinger
2022-01-21 9:33 ` [PATCH v1 1/2] arm64: dts: imx8mq: fix mipi_csi bidirectional port numbers Martin Kepplinger
2022-01-21 9:33 ` [PATCH v1 2/2] arm64: dts: imx8mq-librem5: fix mipi_csi1 port number to sensor Martin Kepplinger
2022-01-29 6:30 ` [PATCH v1 0/2] arm64: dts: imx8mq: fix mipi_csi port numbering Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).