* [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices
@ 2022-01-22 7:32 Christian Hewitt
2022-01-22 7:32 ` [PATCH 1/3] arm64: dts: meson: add BL32 reserved-memory region to GT-King Christian Hewitt
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Christian Hewitt @ 2022-01-22 7:32 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kevin Hilman, Neil Armstrong,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt, Furkan Kardame
This resolves a long-running issue where Beelink GT-King/Pro and
GS-King-X wedge on boot or shortly after when booting from vendor
u-boot. In some distros the issue is often reported as triggered
by large file transfers to/from USB or SD cards. Reserving the
BL32 memory region prevents the issue.
Christian Hewitt (3):
arm64: dts: meson: add BL32 reserved-memory region to GT-King
arm64: dts: meson: add BL32 reserved-memory region to GT-King Pro
arm64: dts: meson: add BL32 reserved-memory region to GS-King-X
arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts | 8 ++++++++
arch/arm64/boot/dts/amlogic/meson-g12b-gtking-pro.dts | 8 ++++++++
arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts | 8 ++++++++
3 files changed, 24 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] arm64: dts: meson: add BL32 reserved-memory region to GT-King
2022-01-22 7:32 [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices Christian Hewitt
@ 2022-01-22 7:32 ` Christian Hewitt
2022-01-22 7:32 ` [PATCH 2/3] arm64: dts: meson: add BL32 reserved-memory region to GT-King Pro Christian Hewitt
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Christian Hewitt @ 2022-01-22 7:32 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kevin Hilman, Neil Armstrong,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt, Furkan Kardame
Add an additional reserved memory region for the BL32 trusted firmware
shipping in Beelink g12b devices. This fixes a long running issue with
boxes booting from Vendor u-boot where the board wedges during boot or
soon after due to the (un)reserved region being overwritten.
Fixes commit c5522ff9c729 ("arm64: dts: meson-g12b-gtking: add initial device-tree")
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
---
arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts
index 5d96c1449050..58a300d6b545 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts
@@ -19,6 +19,14 @@
rtc1 = &vrtc;
};
+ reserved-memory {
+ /* 32 MiB reserved for ARM Trusted Firmware (BL32) */
+ secmon_reserved_bl32: secmon@5300000 {
+ reg = <0x0 0x05300000 0x0 0x2000000>;
+ no-map;
+ };
+ };
+
spdif_dit: audio-codec-1 {
#sound-dai-cells = <0>;
compatible = "linux,spdif-dit";
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] arm64: dts: meson: add BL32 reserved-memory region to GT-King Pro
2022-01-22 7:32 [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices Christian Hewitt
2022-01-22 7:32 ` [PATCH 1/3] arm64: dts: meson: add BL32 reserved-memory region to GT-King Christian Hewitt
@ 2022-01-22 7:32 ` Christian Hewitt
2022-01-22 7:32 ` [PATCH 3/3] arm64: dts: meson: add BL32 reserved-memory region to GS-King-X Christian Hewitt
2022-01-24 20:02 ` [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices Kevin Hilman
3 siblings, 0 replies; 7+ messages in thread
From: Christian Hewitt @ 2022-01-22 7:32 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kevin Hilman, Neil Armstrong,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt, Furkan Kardame
Add an additional reserved memory region for the BL32 trusted firmware
shipping in Beelink g12b devices. This fixes a long running issue with
boxes booting from Vendor u-boot where the board wedges during boot or
soon after due to the (un)reserved region being overwritten.
Fixes commit 0b928e4e412b ("arm64: dts: meson-g12b-gtking-pro: add initial device-tree")
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
---
arch/arm64/boot/dts/amlogic/meson-g12b-gtking-pro.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-gtking-pro.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-gtking-pro.dts
index 707daf92787b..7782fc9fc12b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-gtking-pro.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-gtking-pro.dts
@@ -19,6 +19,14 @@
rtc1 = &vrtc;
};
+ reserved-memory {
+ /* 32 MiB reserved for ARM Trusted Firmware (BL32) */
+ secmon_reserved_bl32: secmon@5300000 {
+ reg = <0x0 0x05300000 0x0 0x2000000>;
+ no-map;
+ };
+ };
+
gpio-keys-polled {
compatible = "gpio-keys-polled";
#address-cells = <1>;
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] arm64: dts: meson: add BL32 reserved-memory region to GS-King-X
2022-01-22 7:32 [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices Christian Hewitt
2022-01-22 7:32 ` [PATCH 1/3] arm64: dts: meson: add BL32 reserved-memory region to GT-King Christian Hewitt
2022-01-22 7:32 ` [PATCH 2/3] arm64: dts: meson: add BL32 reserved-memory region to GT-King Pro Christian Hewitt
@ 2022-01-22 7:32 ` Christian Hewitt
2022-01-24 20:02 ` [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices Kevin Hilman
3 siblings, 0 replies; 7+ messages in thread
From: Christian Hewitt @ 2022-01-22 7:32 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kevin Hilman, Neil Armstrong,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt, Furkan Kardame
Add an additional reserved memory region for the BL32 trusted firmware
shipping in Beelink g12b devices. This fixes a long running issue with
boxes booting from Vendor u-boot where the board wedges during boot or
soon after due to the (un)reserved region being overwritten.
Fixes commit 93db2ce05204 ("arm64: dts: meson: add initial Beelink GS-King-X device-tree")
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Tested-by: Furkan Kardame <furkan@fkardame.com>
---
arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
index 6c7bfacbad78..c6178cbe3a9b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
@@ -20,6 +20,14 @@
rtc1 = &vrtc;
};
+ reserved-memory {
+ /* 32 MiB reserved for ARM Trusted Firmware (BL32) */
+ secmon_reserved_bl32: secmon@5300000 {
+ reg = <0x0 0x05300000 0x0 0x2000000>;
+ no-map;
+ };
+ };
+
gpio-keys-polled {
compatible = "gpio-keys-polled";
#address-cells = <1>;
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices
2022-01-22 7:32 [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices Christian Hewitt
` (2 preceding siblings ...)
2022-01-22 7:32 ` [PATCH 3/3] arm64: dts: meson: add BL32 reserved-memory region to GS-King-X Christian Hewitt
@ 2022-01-24 20:02 ` Kevin Hilman
2022-01-25 4:03 ` Christian Hewitt
[not found] ` <C8B4EA0E-6593-4C42-B116-F9C043D29452@gmail.com>
3 siblings, 2 replies; 7+ messages in thread
From: Kevin Hilman @ 2022-01-24 20:02 UTC (permalink / raw)
To: Christian Hewitt, Rob Herring, Mark Rutland, Neil Armstrong,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt, Furkan Kardame
Christian Hewitt <christianshewitt@gmail.com> writes:
> This resolves a long-running issue where Beelink GT-King/Pro and
> GS-King-X wedge on boot or shortly after when booting from vendor
> u-boot. In some distros the issue is often reported as triggered
> by large file transfers to/from USB or SD cards. Reserving the
> BL32 memory region prevents the issue.
The BL32 is typically common for the SoC family, so this change should
probably go into the g12b.dtsi. Or probably even
meson-g12-common.dtsi, which is where the BL31 reserved-memory is
described.
Kevin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices
2022-01-24 20:02 ` [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices Kevin Hilman
@ 2022-01-25 4:03 ` Christian Hewitt
[not found] ` <C8B4EA0E-6593-4C42-B116-F9C043D29452@gmail.com>
1 sibling, 0 replies; 7+ messages in thread
From: Christian Hewitt @ 2022-01-25 4:03 UTC (permalink / raw)
To: Kevin Hilman
Cc: Rob Herring, Mark Rutland, Neil Armstrong, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel, Furkan Kardame
>
> On 25 Jan 2022, at 12:02 am, Kevin Hilman <khilman@baylibre.com> wrote:
>
> Christian Hewitt <christianshewitt@gmail.com> writes:
>
>> This resolves a long-running issue where Beelink GT-King/Pro and
>> GS-King-X wedge on boot or shortly after when booting from vendor
>> u-boot. In some distros the issue is often reported as triggered
>> by large file transfers to/from USB or SD cards. Reserving the
>> BL32 memory region prevents the issue.
>
> The BL32 is typically common for the SoC family, so this change should
> probably go into the g12b.dtsi. Or probably even
> meson-g12-common.dtsi, which is where the BL31 reserved-memory is
> described.
Hi Kevin,
Would you be okay with the same change applied to GX devices too? - I
normally have these two catch-all patches in my tree to deal with random
tv box hardware and it would be great to drop them:
https://github.com/chewitt/linux/commit/4315ea4612389fc08d0a008b562cafbda96374fc
https://github.com/chewitt/linux/commit/3c0df794baa7ea9d32d8ad54530b5a056c770ea9
Christian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices
[not found] ` <C8B4EA0E-6593-4C42-B116-F9C043D29452@gmail.com>
@ 2022-01-25 15:01 ` Neil Armstrong
0 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2022-01-25 15:01 UTC (permalink / raw)
To: Christian Hewitt, Kevin Hilman
Cc: Rob Herring, Mark Rutland, devicetree, linux-arm-kernel,
linux-amlogic, linux-kernel, Furkan Kardame
Hi,
On 25/01/2022 05:02, Christian Hewitt wrote:
>
>> On 25 Jan 2022, at 12:02 am, Kevin Hilman <khilman@baylibre.com <mailto:khilman@baylibre.com>> wrote:
>>
>> Christian Hewitt <christianshewitt@gmail.com <mailto:christianshewitt@gmail.com>> writes:
>>
>>> This resolves a long-running issue where Beelink GT-King/Pro and
>>> GS-King-X wedge on boot or shortly after when booting from vendor
>>> u-boot. In some distros the issue is often reported as triggered
>>> by large file transfers to/from USB or SD cards. Reserving the
>>> BL32 memory region prevents the issue.
>>
>> The BL32 is typically common for the SoC family, so this change should
>> probably go into the g12b.dtsi. Or probably even
>> meson-g12-common.dtsi, which is where the BL31 reserved-memory is
>> described.
>
> Hi Kevin,
>
> Would you be okay with the same change applied to GX devices too? - I
> normally have these two catch-all patches in my tree to deal with random
> tv box hardware and it would be great to drop them:
>
> https://github.com/chewitt/linux/commit/4315ea4612389fc08d0a008b562cafbda96374fc <https://github.com/chewitt/linux/commit/4315ea4612389fc08d0a008b562cafbda96374fc>
> https://github.com/chewitt/linux/commit/3c0df794baa7ea9d32d8ad54530b5a056c770ea9 <https://github.com/chewitt/linux/commit/3c0df794baa7ea9d32d8ad54530b5a056c770ea9>
Sure, it has been done in a similar way for bl31:
https://github.com/torvalds/linux/commit/48e21ded0432ee1e2359d4143d7a6925cefee1b5
in a perfect work we wouldn't need this since mainline U-Boot does the job by reserving these
memory zones, but vendor u-boot exists and isn't avoidable.
Neil
>
> Christian
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-01-25 15:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-22 7:32 [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices Christian Hewitt
2022-01-22 7:32 ` [PATCH 1/3] arm64: dts: meson: add BL32 reserved-memory region to GT-King Christian Hewitt
2022-01-22 7:32 ` [PATCH 2/3] arm64: dts: meson: add BL32 reserved-memory region to GT-King Pro Christian Hewitt
2022-01-22 7:32 ` [PATCH 3/3] arm64: dts: meson: add BL32 reserved-memory region to GS-King-X Christian Hewitt
2022-01-24 20:02 ` [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices Kevin Hilman
2022-01-25 4:03 ` Christian Hewitt
[not found] ` <C8B4EA0E-6593-4C42-B116-F9C043D29452@gmail.com>
2022-01-25 15:01 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).