From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, kim.phillips@amd.com, acme@redhat.com,
jolsa@redhat.com, songliubraving@fb.com
Subject: [PATCH v5 04/13] perf/x86/amd: add branch-brs helper event for Fam19h BRS
Date: Wed, 26 Jan 2022 15:34:45 -0800 [thread overview]
Message-ID: <20220126233454.3362047-5-eranian@google.com> (raw)
In-Reply-To: <20220126233454.3362047-1-eranian@google.com>
This patch adds a pseudo event called branch-brs to help use the FAM Fam19h
Branch Sampling feature (BRS). BRS samples taken branches, so it is best used
when sampling on a retired taken branch event (0xc4) which is what BRS
captures. Instead of trying to remember the event code or actual event name,
users can simply do:
$ perf record -b -e cpu/branch-brs/ -c 1000037 .....
Signed-off-by: Stephane Eranian <eranian@google.com>
---
arch/x86/events/amd/core.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
index 44d8f618bb3e..597defee1e02 100644
--- a/arch/x86/events/amd/core.c
+++ b/arch/x86/events/amd/core.c
@@ -1105,8 +1105,24 @@ static struct attribute_group group_caps_amd_brs = {
.is_visible = amd_brs_is_visible,
};
+#define AMD_FAM19H_BRS_EVENT 0xc4 /* Fam19h RETIRED_TAKEN_BRANCH_INSTRUCTIONS */
+EVENT_ATTR_STR(branch-brs, amd_branch_brs,
+ "event=" __stringify(AMD_FAM19H_BRS_EVENT)"\n");
+
+static struct attribute *amd_brs_events_attrs[] = {
+ EVENT_PTR(amd_branch_brs),
+ NULL,
+};
+
+static struct attribute_group group_events_amd_brs = {
+ .name = "events",
+ .attrs = amd_brs_events_attrs,
+ .is_visible = amd_brs_is_visible,
+};
+
static const struct attribute_group *amd_attr_update[] = {
&group_caps_amd_brs,
+ &group_events_amd_brs,
NULL,
};
--
2.35.0.rc0.227.g00780c9af4-goog
next prev parent reply other threads:[~2022-01-26 23:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 23:34 [PATCH v5 00/14] perf/x86/amd: Add AMD Fam19h Branch Sampling support Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 01/13] perf/core: add perf_clear_branch_entry_bitfields() helper Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 02/13] x86/cpufeatures: add AMD Fam19h Branch Sampling feature Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support Stephane Eranian
2022-01-26 23:34 ` Stephane Eranian [this message]
2022-01-26 23:34 ` [PATCH v5 05/13] perf/x86/amd: enable branch sampling priv level filtering Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 06/13] perf/x86/amd: add AMD branch sampling period adjustment Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 07/13] perf/x86/amd: make Zen3 branch sampling opt-in Stephane Eranian
2022-01-27 12:51 ` Peter Zijlstra
2022-02-01 7:28 ` Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 08/13] ACPI: add perf low power callback Stephane Eranian
2022-01-27 13:06 ` Peter Zijlstra
2022-02-01 7:33 ` Stephane Eranian
2022-02-01 10:20 ` Peter Zijlstra
2022-01-26 23:34 ` [PATCH v5 09/13] perf/x86/amd: add idle hooks for branch sampling Stephane Eranian
2022-01-27 13:07 ` Peter Zijlstra
2022-02-01 7:34 ` Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 10/13] perf evsel: Make evsel__env always return a valid env Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 11/13] perf tools: Improve IBS error handling Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 12/13] perf tools: Improve error handling of AMD Branch Sampling Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 13/13] perf report: add addr_from/addr_to sort dimensions Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126233454.3362047-5-eranian@google.com \
--to=eranian@google.com \
--cc=acme@redhat.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).