From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, kim.phillips@amd.com,
acme@redhat.com, jolsa@redhat.com, songliubraving@fb.com,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v5 08/13] ACPI: add perf low power callback
Date: Tue, 1 Feb 2022 11:20:29 +0100 [thread overview]
Message-ID: <20220201102029.GS20638@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <CABPqkBQoLh+v0ANLb=U-JTjT0yjBacVLTh6f=0q4J4XhVQeeuQ@mail.gmail.com>
On Mon, Jan 31, 2022 at 11:33:10PM -0800, Stephane Eranian wrote:
> On Thu, Jan 27, 2022 at 5:06 AM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Wed, Jan 26, 2022 at 03:34:49PM -0800, Stephane Eranian wrote:
> > > This patch add an optional callback needed by some PMU features, e.g., AMD
> >
> > "This patch" is a documented fail.
> >
> I understand this is not ideal.
git grep -i "this patch" Documentation/process/submitting-patches.rst
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour."
IOW, don't use "This patch" to start a Changelog (lot's of your patches
here do so).
next prev parent reply other threads:[~2022-02-01 10:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 23:34 [PATCH v5 00/14] perf/x86/amd: Add AMD Fam19h Branch Sampling support Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 01/13] perf/core: add perf_clear_branch_entry_bitfields() helper Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 02/13] x86/cpufeatures: add AMD Fam19h Branch Sampling feature Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 04/13] perf/x86/amd: add branch-brs helper event for Fam19h BRS Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 05/13] perf/x86/amd: enable branch sampling priv level filtering Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 06/13] perf/x86/amd: add AMD branch sampling period adjustment Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 07/13] perf/x86/amd: make Zen3 branch sampling opt-in Stephane Eranian
2022-01-27 12:51 ` Peter Zijlstra
2022-02-01 7:28 ` Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 08/13] ACPI: add perf low power callback Stephane Eranian
2022-01-27 13:06 ` Peter Zijlstra
2022-02-01 7:33 ` Stephane Eranian
2022-02-01 10:20 ` Peter Zijlstra [this message]
2022-01-26 23:34 ` [PATCH v5 09/13] perf/x86/amd: add idle hooks for branch sampling Stephane Eranian
2022-01-27 13:07 ` Peter Zijlstra
2022-02-01 7:34 ` Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 10/13] perf evsel: Make evsel__env always return a valid env Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 11/13] perf tools: Improve IBS error handling Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 12/13] perf tools: Improve error handling of AMD Branch Sampling Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 13/13] perf report: add addr_from/addr_to sort dimensions Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201102029.GS20638@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).