[PATCH v2 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID

[PATCH v2 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID

[Andy Shevchenko]

There is export_uuid() function which exports uuid_t to the u8 array.
Use it instead of open coding variant.

This allows to hide the uuid_t internals.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

v2: resent with Cc to Christoph since the original maintainers are
    non-responsive for mare than a year (previous resent was dated
    2021-01-21).

 drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index a5bf4c3f6dc7..40e3183a3d11 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev)
 		return -ENODEV;
 
 	/* Open session with Bnxt load Trusted App */
-	memcpy(sess_arg.uuid, bnxt_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
+	export_uuid(sess_arg.uuid, &bnxt_device->id.uuid);
 	sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
 	sess_arg.num_params = 0;
 
-- 
2.34.1

Re: [PATCH v2 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID

[Andy Shevchenko]

On Thu, Jan 27, 2022 at 06:01:50PM +0200, Andy Shevchenko wrote:
> There is export_uuid() function which exports uuid_t to the u8 array.
> Use it instead of open coding variant.
> 
> This allows to hide the uuid_t internals.

Any comments, tags? Can it be accepted now?

-- 
With Best Regards,
Andy Shevchenko