linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] firmware: imx: add get resource owner api
@ 2022-01-11  3:21 Peng Fan (OSS)
  2022-01-26  8:23 ` Peng Fan
  2022-01-28  8:56 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan (OSS) @ 2022-01-11  3:21 UTC (permalink / raw)
  To: shawnguo, s.hauer
  Cc: kernel, festevam, linux-imx, linux-arm-kernel, linux-kernel, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

Add resource owner management API, this API could be used to check
whether M4 is under control of Linux.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/firmware/imx/rm.c           | 45 +++++++++++++++++++++++++++++
 include/linux/firmware/imx/svc/rm.h |  5 ++++
 2 files changed, 50 insertions(+)

diff --git a/drivers/firmware/imx/rm.c b/drivers/firmware/imx/rm.c
index a12db6ff323b..3c3605f98123 100644
--- a/drivers/firmware/imx/rm.c
+++ b/drivers/firmware/imx/rm.c
@@ -43,3 +43,48 @@ bool imx_sc_rm_is_resource_owned(struct imx_sc_ipc *ipc, u16 resource)
 	return hdr->func;
 }
 EXPORT_SYMBOL(imx_sc_rm_is_resource_owned);
+
+/*
+ * This function get @resource partition number
+ *
+ * @param[in]     ipc         IPC handle
+ * @param[in]     resource    resource the control is associated with
+ * @param[out]    pt          pointer to return the partition number
+ *
+ * @return Returns 0 for success and < 0 for errors.
+ */
+struct imx_sc_msg_rm_get_resource_owner {
+	struct imx_sc_rpc_msg hdr;
+	union {
+		struct {
+			u16 resource;
+		} req;
+		struct {
+			u8 val;
+		} resp;
+	} data;
+} __packed __aligned(4);
+
+int imx_sc_rm_get_resource_owner(struct imx_sc_ipc *ipc, u16 resource, u8 *pt)
+{
+	struct imx_sc_msg_rm_get_resource_owner msg;
+	struct imx_sc_rpc_msg *hdr = &msg.hdr;
+	int ret;
+
+	hdr->ver = IMX_SC_RPC_VERSION;
+	hdr->svc = IMX_SC_RPC_SVC_RM;
+	hdr->func = IMX_SC_RM_FUNC_GET_RESOURCE_OWNER;
+	hdr->size = 2;
+
+	msg.data.req.resource = resource;
+
+	ret = imx_scu_call_rpc(ipc, &msg, true);
+	if (ret)
+		return ret;
+
+	if (pt)
+		*pt = msg.data.resp.val;
+
+	return 0;
+}
+EXPORT_SYMBOL(imx_sc_rm_get_resource_owner);
diff --git a/include/linux/firmware/imx/svc/rm.h b/include/linux/firmware/imx/svc/rm.h
index 456b6a59d29b..ff481b23ea36 100644
--- a/include/linux/firmware/imx/svc/rm.h
+++ b/include/linux/firmware/imx/svc/rm.h
@@ -59,11 +59,16 @@ enum imx_sc_rm_func {
 
 #if IS_ENABLED(CONFIG_IMX_SCU)
 bool imx_sc_rm_is_resource_owned(struct imx_sc_ipc *ipc, u16 resource);
+int imx_sc_rm_get_resource_owner(struct imx_sc_ipc *ipc, u16 resource, u8 *pt);
 #else
 static inline bool
 imx_sc_rm_is_resource_owned(struct imx_sc_ipc *ipc, u16 resource)
 {
 	return true;
 }
+static inline int imx_sc_rm_get_resource_owner(struct imx_sc_ipc *ipc, u16 resource, u8 *pt)
+{
+	return -ENOTSUPP;
+}
 #endif
 #endif
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] firmware: imx: add get resource owner api
  2022-01-11  3:21 [PATCH] firmware: imx: add get resource owner api Peng Fan (OSS)
@ 2022-01-26  8:23 ` Peng Fan
  2022-01-28  8:56 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2022-01-26  8:23 UTC (permalink / raw)
  To: Peng Fan (OSS), shawnguo, s.hauer
  Cc: kernel, festevam, dl-linux-imx, linux-arm-kernel, linux-kernel

> Subject: [PATCH] firmware: imx: add get resource owner api

Ping.. we need this API for remoteproc partition case.

Thanks,
Peng.

> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add resource owner management API, this API could be used to check
> whether M4 is under control of Linux.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/firmware/imx/rm.c           | 45
> +++++++++++++++++++++++++++++
>  include/linux/firmware/imx/svc/rm.h |  5 ++++
>  2 files changed, 50 insertions(+)
> 
> diff --git a/drivers/firmware/imx/rm.c b/drivers/firmware/imx/rm.c index
> a12db6ff323b..3c3605f98123 100644
> --- a/drivers/firmware/imx/rm.c
> +++ b/drivers/firmware/imx/rm.c
> @@ -43,3 +43,48 @@ bool imx_sc_rm_is_resource_owned(struct imx_sc_ipc
> *ipc, u16 resource)
>  	return hdr->func;
>  }
>  EXPORT_SYMBOL(imx_sc_rm_is_resource_owned);
> +
> +/*
> + * This function get @resource partition number
> + *
> + * @param[in]     ipc         IPC handle
> + * @param[in]     resource    resource the control is associated with
> + * @param[out]    pt          pointer to return the partition number
> + *
> + * @return Returns 0 for success and < 0 for errors.
> + */
> +struct imx_sc_msg_rm_get_resource_owner {
> +	struct imx_sc_rpc_msg hdr;
> +	union {
> +		struct {
> +			u16 resource;
> +		} req;
> +		struct {
> +			u8 val;
> +		} resp;
> +	} data;
> +} __packed __aligned(4);
> +
> +int imx_sc_rm_get_resource_owner(struct imx_sc_ipc *ipc, u16 resource,
> +u8 *pt) {
> +	struct imx_sc_msg_rm_get_resource_owner msg;
> +	struct imx_sc_rpc_msg *hdr = &msg.hdr;
> +	int ret;
> +
> +	hdr->ver = IMX_SC_RPC_VERSION;
> +	hdr->svc = IMX_SC_RPC_SVC_RM;
> +	hdr->func = IMX_SC_RM_FUNC_GET_RESOURCE_OWNER;
> +	hdr->size = 2;
> +
> +	msg.data.req.resource = resource;
> +
> +	ret = imx_scu_call_rpc(ipc, &msg, true);
> +	if (ret)
> +		return ret;
> +
> +	if (pt)
> +		*pt = msg.data.resp.val;
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL(imx_sc_rm_get_resource_owner);
> diff --git a/include/linux/firmware/imx/svc/rm.h
> b/include/linux/firmware/imx/svc/rm.h
> index 456b6a59d29b..ff481b23ea36 100644
> --- a/include/linux/firmware/imx/svc/rm.h
> +++ b/include/linux/firmware/imx/svc/rm.h
> @@ -59,11 +59,16 @@ enum imx_sc_rm_func {
> 
>  #if IS_ENABLED(CONFIG_IMX_SCU)
>  bool imx_sc_rm_is_resource_owned(struct imx_sc_ipc *ipc, u16 resource);
> +int imx_sc_rm_get_resource_owner(struct imx_sc_ipc *ipc, u16 resource,
> +u8 *pt);
>  #else
>  static inline bool
>  imx_sc_rm_is_resource_owned(struct imx_sc_ipc *ipc, u16 resource)  {
>  	return true;
>  }
> +static inline int imx_sc_rm_get_resource_owner(struct imx_sc_ipc *ipc,
> +u16 resource, u8 *pt) {
> +	return -ENOTSUPP;
> +}
>  #endif
>  #endif
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] firmware: imx: add get resource owner api
  2022-01-11  3:21 [PATCH] firmware: imx: add get resource owner api Peng Fan (OSS)
  2022-01-26  8:23 ` Peng Fan
@ 2022-01-28  8:56 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2022-01-28  8:56 UTC (permalink / raw)
  To: Peng Fan (OSS)
  Cc: s.hauer, kernel, festevam, linux-imx, linux-arm-kernel,
	linux-kernel, Peng Fan

On Tue, Jan 11, 2022 at 11:21:47AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add resource owner management API, this API could be used to check
> whether M4 is under control of Linux.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/firmware/imx/rm.c           | 45 +++++++++++++++++++++++++++++
>  include/linux/firmware/imx/svc/rm.h |  5 ++++
>  2 files changed, 50 insertions(+)
> 
> diff --git a/drivers/firmware/imx/rm.c b/drivers/firmware/imx/rm.c
> index a12db6ff323b..3c3605f98123 100644
> --- a/drivers/firmware/imx/rm.c
> +++ b/drivers/firmware/imx/rm.c
> @@ -43,3 +43,48 @@ bool imx_sc_rm_is_resource_owned(struct imx_sc_ipc *ipc, u16 resource)
>  	return hdr->func;
>  }
>  EXPORT_SYMBOL(imx_sc_rm_is_resource_owned);
> +
> +/*
> + * This function get @resource partition number
> + *
> + * @param[in]     ipc         IPC handle
> + * @param[in]     resource    resource the control is associated with
> + * @param[out]    pt          pointer to return the partition number
> + *
> + * @return Returns 0 for success and < 0 for errors.
> + */

Shouldn't the documentation be put right above the function?

Shawn

> +struct imx_sc_msg_rm_get_resource_owner {
> +	struct imx_sc_rpc_msg hdr;
> +	union {
> +		struct {
> +			u16 resource;
> +		} req;
> +		struct {
> +			u8 val;
> +		} resp;
> +	} data;
> +} __packed __aligned(4);
> +
> +int imx_sc_rm_get_resource_owner(struct imx_sc_ipc *ipc, u16 resource, u8 *pt)
> +{
> +	struct imx_sc_msg_rm_get_resource_owner msg;
> +	struct imx_sc_rpc_msg *hdr = &msg.hdr;
> +	int ret;
> +
> +	hdr->ver = IMX_SC_RPC_VERSION;
> +	hdr->svc = IMX_SC_RPC_SVC_RM;
> +	hdr->func = IMX_SC_RM_FUNC_GET_RESOURCE_OWNER;
> +	hdr->size = 2;
> +
> +	msg.data.req.resource = resource;
> +
> +	ret = imx_scu_call_rpc(ipc, &msg, true);
> +	if (ret)
> +		return ret;
> +
> +	if (pt)
> +		*pt = msg.data.resp.val;
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL(imx_sc_rm_get_resource_owner);
> diff --git a/include/linux/firmware/imx/svc/rm.h b/include/linux/firmware/imx/svc/rm.h
> index 456b6a59d29b..ff481b23ea36 100644
> --- a/include/linux/firmware/imx/svc/rm.h
> +++ b/include/linux/firmware/imx/svc/rm.h
> @@ -59,11 +59,16 @@ enum imx_sc_rm_func {
>  
>  #if IS_ENABLED(CONFIG_IMX_SCU)
>  bool imx_sc_rm_is_resource_owned(struct imx_sc_ipc *ipc, u16 resource);
> +int imx_sc_rm_get_resource_owner(struct imx_sc_ipc *ipc, u16 resource, u8 *pt);
>  #else
>  static inline bool
>  imx_sc_rm_is_resource_owned(struct imx_sc_ipc *ipc, u16 resource)
>  {
>  	return true;
>  }
> +static inline int imx_sc_rm_get_resource_owner(struct imx_sc_ipc *ipc, u16 resource, u8 *pt)
> +{
> +	return -ENOTSUPP;
> +}
>  #endif
>  #endif
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-28  8:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-11  3:21 [PATCH] firmware: imx: add get resource owner api Peng Fan (OSS)
2022-01-26  8:23 ` Peng Fan
2022-01-28  8:56 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).