* [ammarfaizi2-block:paulmck/linux-rcu/dev 94/94] kernel/rcu/srcutree.c:313:6: warning: no previous prototype for function 'spin_lock_irqsave_ssp_contention'
@ 2022-01-28 11:18 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-01-28 11:18 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: llvm, kbuild-all, GNU/Weeb Mailing List, linux-kernel
tree: https://github.com/ammarfaizi2/linux-block paulmck/linux-rcu/dev
head: 903a93309e5a59497d3c178cabb67ecc6c843a69
commit: 903a93309e5a59497d3c178cabb67ecc6c843a69 [94/94] srcu: Add contention-triggered addition of srcu_node tree
config: hexagon-randconfig-r015-20220128 (https://download.01.org/0day-ci/archive/20220128/202201281904.qRllNV38-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 33b45ee44b1f32ffdbc995e6fec806271b4b3ba4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/903a93309e5a59497d3c178cabb67ecc6c843a69
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block paulmck/linux-rcu/dev
git checkout 903a93309e5a59497d3c178cabb67ecc6c843a69
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/firewire/ kernel/rcu/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> kernel/rcu/srcutree.c:313:6: warning: no previous prototype for function 'spin_lock_irqsave_ssp_contention' [-Wmissing-prototypes]
void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
^
kernel/rcu/srcutree.c:313:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
^
static
1 warning generated.
vim +/spin_lock_irqsave_ssp_contention +313 kernel/rcu/srcutree.c
306
307 /*
308 * Acquire the specified srcu_struct structure's ->lock, but check for
309 * excessive contention, which results in initiation of a transition
310 * to SRCU_SIZE_BIG. But only if the srcutree.convert_to_big module
311 * parameter permits this.
312 */
> 313 void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
314 {
315 unsigned long j;
316
317 if (spin_trylock_irqsave_rcu_node(ssp, *flags))
318 return;
319 spin_lock_irqsave_rcu_node(ssp, *flags);
320 if (!(convert_to_big & 0x10) || ssp->srcu_size_state)
321 return;
322 j = jiffies;
323 if (ssp->srcu_size_jiffies != j) {
324 ssp->srcu_size_jiffies = j;
325 ssp->srcu_n_lock_retries = 0;
326 }
327 if (++ssp->srcu_n_lock_retries <= small_contention_lim)
328 return;
329 __srcu_transition_to_big(ssp);
330 }
331
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ammarfaizi2-block:paulmck/linux-rcu/dev 94/94] kernel/rcu/srcutree.c:313:6: warning: no previous prototype for function 'spin_lock_irqsave_ssp_contention'
2022-01-28 11:07 kernel test robot
@ 2022-01-28 16:18 ` Paul E. McKenney
0 siblings, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2022-01-28 16:18 UTC (permalink / raw)
To: kernel test robot; +Cc: llvm, kbuild-all, GNU/Weeb Mailing List, linux-kernel
On Fri, Jan 28, 2022 at 07:07:42PM +0800, kernel test robot wrote:
> tree: https://github.com/ammarfaizi2/linux-block paulmck/linux-rcu/dev
> head: 903a93309e5a59497d3c178cabb67ecc6c843a69
> commit: 903a93309e5a59497d3c178cabb67ecc6c843a69 [94/94] srcu: Add contention-triggered addition of srcu_node tree
> config: arm-s5pv210_defconfig (https://download.01.org/0day-ci/archive/20220128/202201281920.PD1buizH-lkp@intel.com/config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 33b45ee44b1f32ffdbc995e6fec806271b4b3ba4)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm cross compiling tool for clang build
> # apt-get install binutils-arm-linux-gnueabi
> # https://github.com/ammarfaizi2/linux-block/commit/903a93309e5a59497d3c178cabb67ecc6c843a69
> git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
> git fetch --no-tags ammarfaizi2-block paulmck/linux-rcu/dev
> git checkout 903a93309e5a59497d3c178cabb67ecc6c843a69
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash kernel/rcu/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
I will fold in addition of "static" with attribution, thank you!
Thanx, Paul
> All warnings (new ones prefixed by >>):
>
> >> kernel/rcu/srcutree.c:313:6: warning: no previous prototype for function 'spin_lock_irqsave_ssp_contention' [-Wmissing-prototypes]
> void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
> ^
> kernel/rcu/srcutree.c:313:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
> ^
> static
> 1 warning generated.
>
>
> vim +/spin_lock_irqsave_ssp_contention +313 kernel/rcu/srcutree.c
>
> 306
> 307 /*
> 308 * Acquire the specified srcu_struct structure's ->lock, but check for
> 309 * excessive contention, which results in initiation of a transition
> 310 * to SRCU_SIZE_BIG. But only if the srcutree.convert_to_big module
> 311 * parameter permits this.
> 312 */
> > 313 void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
> 314 {
> 315 unsigned long j;
> 316
> 317 if (spin_trylock_irqsave_rcu_node(ssp, *flags))
> 318 return;
> 319 spin_lock_irqsave_rcu_node(ssp, *flags);
> 320 if (!(convert_to_big & 0x10) || ssp->srcu_size_state)
> 321 return;
> 322 j = jiffies;
> 323 if (ssp->srcu_size_jiffies != j) {
> 324 ssp->srcu_size_jiffies = j;
> 325 ssp->srcu_n_lock_retries = 0;
> 326 }
> 327 if (++ssp->srcu_n_lock_retries <= small_contention_lim)
> 328 return;
> 329 __srcu_transition_to_big(ssp);
> 330 }
> 331
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ammarfaizi2-block:paulmck/linux-rcu/dev 94/94] kernel/rcu/srcutree.c:313:6: warning: no previous prototype for function 'spin_lock_irqsave_ssp_contention'
@ 2022-01-28 11:07 kernel test robot
2022-01-28 16:18 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2022-01-28 11:07 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: llvm, kbuild-all, GNU/Weeb Mailing List, linux-kernel
tree: https://github.com/ammarfaizi2/linux-block paulmck/linux-rcu/dev
head: 903a93309e5a59497d3c178cabb67ecc6c843a69
commit: 903a93309e5a59497d3c178cabb67ecc6c843a69 [94/94] srcu: Add contention-triggered addition of srcu_node tree
config: arm-s5pv210_defconfig (https://download.01.org/0day-ci/archive/20220128/202201281920.PD1buizH-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 33b45ee44b1f32ffdbc995e6fec806271b4b3ba4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/ammarfaizi2/linux-block/commit/903a93309e5a59497d3c178cabb67ecc6c843a69
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block paulmck/linux-rcu/dev
git checkout 903a93309e5a59497d3c178cabb67ecc6c843a69
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash kernel/rcu/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> kernel/rcu/srcutree.c:313:6: warning: no previous prototype for function 'spin_lock_irqsave_ssp_contention' [-Wmissing-prototypes]
void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
^
kernel/rcu/srcutree.c:313:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
^
static
1 warning generated.
vim +/spin_lock_irqsave_ssp_contention +313 kernel/rcu/srcutree.c
306
307 /*
308 * Acquire the specified srcu_struct structure's ->lock, but check for
309 * excessive contention, which results in initiation of a transition
310 * to SRCU_SIZE_BIG. But only if the srcutree.convert_to_big module
311 * parameter permits this.
312 */
> 313 void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
314 {
315 unsigned long j;
316
317 if (spin_trylock_irqsave_rcu_node(ssp, *flags))
318 return;
319 spin_lock_irqsave_rcu_node(ssp, *flags);
320 if (!(convert_to_big & 0x10) || ssp->srcu_size_state)
321 return;
322 j = jiffies;
323 if (ssp->srcu_size_jiffies != j) {
324 ssp->srcu_size_jiffies = j;
325 ssp->srcu_n_lock_retries = 0;
326 }
327 if (++ssp->srcu_n_lock_retries <= small_contention_lim)
328 return;
329 __srcu_transition_to_big(ssp);
330 }
331
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-28 16:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-28 11:18 [ammarfaizi2-block:paulmck/linux-rcu/dev 94/94] kernel/rcu/srcutree.c:313:6: warning: no previous prototype for function 'spin_lock_irqsave_ssp_contention' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-01-28 11:07 kernel test robot
2022-01-28 16:18 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).