* [PATCH] RDMA/mlx4: remove redundant assignment to variable nreq
@ 2022-01-30 22:57 Colin Ian King
2022-02-01 15:02 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-01-30 22:57 UTC (permalink / raw)
To: Yishai Hadas, Jason Gunthorpe, linux-rdma; +Cc: kernel-janitors, linux-kernel
Variable nreq is being assigned a value that is never read. The
assignment is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/infiniband/hw/mlx4/srq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx4/srq.c b/drivers/infiniband/hw/mlx4/srq.c
index 6a381751c0d8..c4cf91235eee 100644
--- a/drivers/infiniband/hw/mlx4/srq.c
+++ b/drivers/infiniband/hw/mlx4/srq.c
@@ -320,7 +320,6 @@ int mlx4_ib_post_srq_recv(struct ib_srq *ibsrq, const struct ib_recv_wr *wr,
if (mdev->dev->persist->state & MLX4_DEVICE_STATE_INTERNAL_ERROR) {
err = -EIO;
*bad_wr = wr;
- nreq = 0;
goto out;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] RDMA/mlx4: remove redundant assignment to variable nreq
2022-01-30 22:57 [PATCH] RDMA/mlx4: remove redundant assignment to variable nreq Colin Ian King
@ 2022-02-01 15:02 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2022-02-01 15:02 UTC (permalink / raw)
To: Colin Ian King; +Cc: Yishai Hadas, linux-rdma, kernel-janitors, linux-kernel
On Sun, Jan 30, 2022 at 10:57:47PM +0000, Colin Ian King wrote:
> Variable nreq is being assigned a value that is never read. The
> assignment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/infiniband/hw/mlx4/srq.c | 1 -
> 1 file changed, 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-01 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-30 22:57 [PATCH] RDMA/mlx4: remove redundant assignment to variable nreq Colin Ian King
2022-02-01 15:02 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).