* [PATCH -next 1/2 v2] video: fbdev: pxa168fb: Remove unnecessary print function dev_err()
@ 2022-02-01 12:32 Yang Li
2022-02-01 12:32 ` [PATCH -next 2/2 v2] video: fbdev: pxa3xx-gcu: " Yang Li
2022-02-01 19:47 ` [PATCH -next 1/2 v2] video: fbdev: pxa168fb: " Helge Deller
0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2022-02-01 12:32 UTC (permalink / raw)
To: deller; +Cc: linux-fbdev, dri-devel, linux-kernel, Yang Li, Abaci Robot
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
Eliminate the follow coccicheck warning:
./drivers/video/fbdev/pxa168fb.c:621:2-9: line 621 is redundant because
platform_get_irq() already prints an error
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
-Change in v2:
drop the surrounding braces
drivers/video/fbdev/pxa168fb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
index c25739f6934d..e943300d23e8 100644
--- a/drivers/video/fbdev/pxa168fb.c
+++ b/drivers/video/fbdev/pxa168fb.c
@@ -617,10 +617,8 @@ static int pxa168fb_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "no IRQ defined\n");
+ if (irq < 0)
return -ENOENT;
- }
info = framebuffer_alloc(sizeof(struct pxa168fb_info), &pdev->dev);
if (info == NULL) {
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -next 2/2 v2] video: fbdev: pxa3xx-gcu: Remove unnecessary print function dev_err()
2022-02-01 12:32 [PATCH -next 1/2 v2] video: fbdev: pxa168fb: Remove unnecessary print function dev_err() Yang Li
@ 2022-02-01 12:32 ` Yang Li
2022-02-01 19:47 ` [PATCH -next 1/2 v2] video: fbdev: pxa168fb: " Helge Deller
1 sibling, 0 replies; 3+ messages in thread
From: Yang Li @ 2022-02-01 12:32 UTC (permalink / raw)
To: deller; +Cc: linux-fbdev, dri-devel, linux-kernel, Yang Li, Abaci Robot
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
Eliminate the follow coccicheck warning:
./drivers/video/fbdev/pxa3xx-gcu.c:615:2-9: line 615 is redundant
because platform_get_irq() already prints an error
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
-Change in v2:
drop the surrounding braces
drivers/video/fbdev/pxa3xx-gcu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
index 9239ecd34169..350b3139c863 100644
--- a/drivers/video/fbdev/pxa3xx-gcu.c
+++ b/drivers/video/fbdev/pxa3xx-gcu.c
@@ -611,10 +611,8 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev)
/* request the IRQ */
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(dev, "no IRQ defined: %d\n", irq);
+ if (irq < 0)
return irq;
- }
ret = devm_request_irq(dev, irq, pxa3xx_gcu_handle_irq,
0, DRV_NAME, priv);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next 1/2 v2] video: fbdev: pxa168fb: Remove unnecessary print function dev_err()
2022-02-01 12:32 [PATCH -next 1/2 v2] video: fbdev: pxa168fb: Remove unnecessary print function dev_err() Yang Li
2022-02-01 12:32 ` [PATCH -next 2/2 v2] video: fbdev: pxa3xx-gcu: " Yang Li
@ 2022-02-01 19:47 ` Helge Deller
1 sibling, 0 replies; 3+ messages in thread
From: Helge Deller @ 2022-02-01 19:47 UTC (permalink / raw)
To: Yang Li; +Cc: linux-fbdev, dri-devel, linux-kernel, Abaci Robot
On 2/1/22 13:32, Yang Li wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/video/fbdev/pxa168fb.c:621:2-9: line 621 is redundant because
> platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>
> -Change in v2:
> drop the surrounding braces
Both applied to fbdev-next tree.
Thanks,
Helge
>
> drivers/video/fbdev/pxa168fb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
> index c25739f6934d..e943300d23e8 100644
> --- a/drivers/video/fbdev/pxa168fb.c
> +++ b/drivers/video/fbdev/pxa168fb.c
> @@ -617,10 +617,8 @@ static int pxa168fb_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(&pdev->dev, "no IRQ defined\n");
> + if (irq < 0)
> return -ENOENT;
> - }
>
> info = framebuffer_alloc(sizeof(struct pxa168fb_info), &pdev->dev);
> if (info == NULL) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-01 19:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-01 12:32 [PATCH -next 1/2 v2] video: fbdev: pxa168fb: Remove unnecessary print function dev_err() Yang Li
2022-02-01 12:32 ` [PATCH -next 2/2 v2] video: fbdev: pxa3xx-gcu: " Yang Li
2022-02-01 19:47 ` [PATCH -next 1/2 v2] video: fbdev: pxa168fb: " Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).