From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Stefan Mätje" <stefan.maetje@esd.eu>
Cc: linux-can@vger.kernel.org,
Wolfgang Grandegger <wg@grandegger.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/4] can: esd: add support for esd GmbH PCIe/402 CAN interface
Date: Tue, 1 Feb 2022 18:27:06 +0100 [thread overview]
Message-ID: <20220201172706.dprwxzx3qbsmpuwm@pengutronix.de> (raw)
In-Reply-To: <20211201220328.3079270-1-stefan.maetje@esd.eu>
[-- Attachment #1: Type: text/plain, Size: 2199 bytes --]
On 01.12.2021 23:03:24, Stefan Mätje wrote:
> The purpose of this patch is to introduce a new CAN driver to support
> the esd GmbH 402 family of CAN interface boards. The hardware design
> is based on a CAN controller implemented in a FPGA attached to a
> PCIe link.
>
> More information on these boards can be found following the links
> included in the commit message.
>
> This patch supports all boards but will operate the CAN-FD capable
> boards only in Classic-CAN mode. The CAN-FD support will be added
> when the initial patch has stabilized.
>
> The patch is reuses the previous work of my former colleague:
> Link: https://lore.kernel.org/linux-can/1426592308-23817-1-git-send-email-thomas.koerper@esd.eu/
>
> *Note*: scripts/checkpatch.pl still emits the following warnings:
> - esd_402_pci-core.c:270: Possible unnecessary 'out of memory' message
> This error message is there to tell the user that the DMA allocation
> failed and not an allocation for normal kernel memory.
> - esdacc.h:255: The irq_cnt pointer is still declared volatile and
> this has a reason and is explained in detail in the header
> referencing the exception noted in volatile-considered-harmful.rst.
>
> The patch is based on the linux-can-next testing branch.
>
> Changes in v6:
> - Fixed the statistic handling of RX overrun errors and increase
> net_device_stats::rx_errors instead of net_device_stats::rx_dropped.
> - Added a patch to not increase rx statistics when generating a CAN
> rx error message frame as suggested on the linux-can list.
> - Added a patch to not not increase rx_bytes statistics for RTR frames
> as suggested on the linux-can list.
>
> The last two patches change the statistics handling from the previous
> style used in other drivers to the newly suggested one.
Please squash the last 2 patches into patch 2.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-02-01 17:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 22:03 [PATCH 0/4] can: esd: add support for esd GmbH PCIe/402 CAN interface Stefan Mätje
2021-12-01 22:03 ` [PATCH 1/4] MAINTAINERS: add Stefan Mätje as maintainer for the esd electronics GmbH CAN drivers Stefan Mätje
2021-12-01 22:03 ` [PATCH 2/4] can: esd: add support for esd GmbH PCIe/402 CAN interface family Stefan Mätje
2022-02-01 17:25 ` [PATCH v6 " Marc Kleine-Budde
2022-09-30 22:15 ` Stefan Mätje
2022-10-05 16:04 ` Marc Kleine-Budde
2021-12-01 22:03 ` [PATCH 3/4] can: esd_402_pci: do not increase rx statistics when generating a CAN rx error message frame Stefan Mätje
2021-12-01 22:03 ` [PATCH 4/4] can: esd_402_pci: do not increase rx_bytes statistics for RTR frames Stefan Mätje
2021-12-01 22:09 ` [PATCH v6 0/4] can: esd: add support for esd GmbH PCIe/402 CAN interface Stefan Mätje
2022-01-07 13:40 ` Stefan Mätje
2022-01-25 16:25 ` Marc Kleine-Budde
2022-01-27 19:14 ` Stefan Mätje
2022-01-28 8:11 ` Marc Kleine-Budde
2022-02-01 17:27 ` Marc Kleine-Budde [this message]
2022-02-02 12:21 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201172706.dprwxzx3qbsmpuwm@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan.maetje@esd.eu \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).