From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Stefan Mätje" <Stefan.Maetje@esd.eu>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"wg@grandegger.com" <wg@grandegger.com>
Subject: Re: [PATCH v6 2/4] can: esd: add support for esd GmbH PCIe/402 CAN interface family
Date: Wed, 5 Oct 2022 18:04:05 +0200 [thread overview]
Message-ID: <20221005160405.xcxecyic3nqhuhht@pengutronix.de> (raw)
In-Reply-To: <fa770d67ed8bb7feea08954ebf25d5c9bebbe700.camel@esd.eu>
[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]
On 30.09.2022 22:15:59, Stefan Mätje wrote:
> I would like to resume the efforts to bring this driver in the Linux
> kernel after being kicked off track in February by another project.
\o/
> I did a lot of the changes on the driver you recommended, but some
> stuff is not yet clear to me. Please see my comments in-line of the
> email below.
>
> My local developement is at the moment rebased to
> linux-can-next:master on 7b584fbb36362340a2d9cfe459e447619eecebea.
> Should I send a V7 of the patch (rebased to another commit)? How
> should I proceed?
You can use latest net-next/main as base version.
> You have commented on many type casts that they would not be needed.
> But all of them had been introduced by me due to warnings of the
> compiler in the style of "warning: conversion from ‘u32’ {aka
> ‘unsigned int’} to ‘u8’ {aka ‘unsigned char’} may change value
> [-Wconversion]". These are triggered by building the driver with "W=3"
> as recommended in kernel documentation.
Oh? Is there a recommendation for W=3? I can only find a W=1:
| https://elixir.bootlin.com/linux/v6.0/source/Documentation/process/maintainer-netdev.rst#L235
> Should these warnings generally be ignored and the casts be removed
> then?
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-05 16:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 22:03 [PATCH 0/4] can: esd: add support for esd GmbH PCIe/402 CAN interface Stefan Mätje
2021-12-01 22:03 ` [PATCH 1/4] MAINTAINERS: add Stefan Mätje as maintainer for the esd electronics GmbH CAN drivers Stefan Mätje
2021-12-01 22:03 ` [PATCH 2/4] can: esd: add support for esd GmbH PCIe/402 CAN interface family Stefan Mätje
2022-02-01 17:25 ` [PATCH v6 " Marc Kleine-Budde
2022-09-30 22:15 ` Stefan Mätje
2022-10-05 16:04 ` Marc Kleine-Budde [this message]
2021-12-01 22:03 ` [PATCH 3/4] can: esd_402_pci: do not increase rx statistics when generating a CAN rx error message frame Stefan Mätje
2021-12-01 22:03 ` [PATCH 4/4] can: esd_402_pci: do not increase rx_bytes statistics for RTR frames Stefan Mätje
2021-12-01 22:09 ` [PATCH v6 0/4] can: esd: add support for esd GmbH PCIe/402 CAN interface Stefan Mätje
2022-01-07 13:40 ` Stefan Mätje
2022-01-25 16:25 ` Marc Kleine-Budde
2022-01-27 19:14 ` Stefan Mätje
2022-01-28 8:11 ` Marc Kleine-Budde
2022-02-01 17:27 ` Marc Kleine-Budde
2022-02-02 12:21 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005160405.xcxecyic3nqhuhht@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=Stefan.Maetje@esd.eu \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).