linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Xu <dxu@dxuuu.xyz>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: "Nick Alcock" <nick.alcock@oracle.com>,
	"bas smit" <bas@baslab.org>, "Tomáš Glozar" <tglozar@gmail.com>,
	Ast-x64 <Ast-x64@protonmail.com>,
	"Viktor Malik" <viktor.malik@gmail.com>,
	"Jiri Olsa" <jolsa@kernel.org>,
	jeyu@kernel.org, masahiroy@kernel.org,
	linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
	arnd@arndb.de, akpm@linux-foundation.org, eugene.loh@oracle.com,
	kris.van.hees@oracle.com
Subject: Re: [PING PATCH v7] kallsyms: new /proc/kallmodsyms with builtin modules
Date: Wed, 2 Feb 2022 10:10:47 -0800	[thread overview]
Message-ID: <20220202181047.frwirxdpufwzkbv3@kashmir.localdomain> (raw)
In-Reply-To: <Yfn145FyE3PDBEad@bombadil.infradead.org>

Hi Luis, Nick,

On Tue, Feb 01, 2022 at 07:09:23PM -0800, Luis Chamberlain wrote:
[...]
> 
> I don't see much traction based on what you have said on dtrace
> on anything other than Oracle Linux stuff, it would be nice if bpftrace
> folks were excited about your changes and we had support for that
> there.

I took a quick look at the v7 cover letter (I'll take a look at
discussion from previous versions later if I get time) and it's not
immediately obvious to me why a stable mapping is beneficial.

Nick, could you elaborate why it's beneficial for dtrace to have a
stable mapping?

For what it's worth, bpftrace uses /proc/kallsyms rather rarely.
bpftrace relies on perf_event_open()'s config1 parameter to resolve
kernel symbol name to address for kprobe attachment. /proc/kallsyms is
mostly used to resolve kaddr() calls in bpftrace scripts.

Kernel symbol size information would be useful, though. bpftrace
currently uses the vmlinux ELF to acquire that information.

[...]

Thanks,
Daniel

  parent reply	other threads:[~2022-02-02 18:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 20:19 [PING PATCH v7] kallsyms: new /proc/kallmodsyms with builtin modules Nick Alcock
2021-12-16 20:19 ` [PATCH v7 1/7] kbuild: bring back tristate.conf Nick Alcock
2021-12-16 20:19 ` [PATCH v7 2/7] kbuild: add modules_thick.builtin Nick Alcock
2021-12-16 20:19 ` [PATCH v7 3/7] kbuild: generate an address ranges map at vmlinux link time Nick Alcock
2021-12-16 20:19 ` [PATCH v7 4/7] kallsyms: introduce sections needed to map symbols to built-in modules Nick Alcock
2021-12-16 20:19 ` [PATCH v7 5/7] kallsyms: optimize .kallsyms_modules* Nick Alcock
2021-12-16 20:19 ` [PATCH v7 6/7] kallsyms: add /proc/kallmodsyms Nick Alcock
2021-12-16 20:19 ` [PATCH v7 7/7] kallsyms: add reliable symbol size info Nick Alcock
2021-12-19 14:05   ` [kallsyms] a42fff4e29: leaking-addresses.proc.kallmodsyms.0T_stext kernel test robot
2022-01-12 16:30 ` [PING PATCH v7] kallsyms: new /proc/kallmodsyms with builtin modules Luis Chamberlain
2022-01-12 16:59   ` Nick Alcock
2022-02-02  3:09     ` Luis Chamberlain
2022-02-02  3:39       ` Kris Van Hees
2022-02-02 18:10       ` Daniel Xu [this message]
2022-02-03 14:11         ` Nick Alcock
2022-02-02 18:37       ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220202181047.frwirxdpufwzkbv3@kashmir.localdomain \
    --to=dxu@dxuuu.xyz \
    --cc=Ast-x64@protonmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=bas@baslab.org \
    --cc=eugene.loh@oracle.com \
    --cc=jeyu@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=kris.van.hees@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=nick.alcock@oracle.com \
    --cc=tglozar@gmail.com \
    --cc=viktor.malik@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).