From: Luis Chamberlain <mcgrof@kernel.org>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: jeyu@kernel.org, masahiroy@kernel.org,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, akpm@linux-foundation.org, eugene.loh@oracle.com,
kris.van.hees@oracle.com
Subject: Re: [PING PATCH v7] kallsyms: new /proc/kallmodsyms with builtin modules
Date: Wed, 12 Jan 2022 08:30:04 -0800 [thread overview]
Message-ID: <Yd8CDJA0dy0VaXrB@bombadil.infradead.org> (raw)
In-Reply-To: <20211216201919.234994-1-nick.alcock@oracle.com>
On Thu, Dec 16, 2021 at 08:19:12PM +0000, Nick Alcock wrote:
> /proc/kallsyms is very useful for tracers and other tools that need to
> map kernel symbols to addresses.
>
> It would be useful
It took me digging on archives to see to *who* this is useful to.
The short answer seeme to be dtrace. Can you work on getting use
of this for something (I don't know, maybe kernelshark?) that does
not taint the kernel? Last I checked using dtrace on linux taints the
kernel.
Without valid upstream users I see no need to add more complexity to the
kernel. And complexity added by tainting modules or not upstream modules
just implies maintaining something for someone who is not working
upstream. I don't want to add more code or "features" to create a
maintenance burden for code not upstream or code that taints the kernel.
module.c is already the second largest file on the kernel/ directory and
I want to ensure we keep it clean, not add fluff for speculated features
which no proper non-taining Linux tool is using.
Without a valid non-taining user being made very clear with a value-add,
I will have to ignore this.
Luis
next prev parent reply other threads:[~2022-01-12 16:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 20:19 [PING PATCH v7] kallsyms: new /proc/kallmodsyms with builtin modules Nick Alcock
2021-12-16 20:19 ` [PATCH v7 1/7] kbuild: bring back tristate.conf Nick Alcock
2021-12-16 20:19 ` [PATCH v7 2/7] kbuild: add modules_thick.builtin Nick Alcock
2021-12-16 20:19 ` [PATCH v7 3/7] kbuild: generate an address ranges map at vmlinux link time Nick Alcock
2021-12-16 20:19 ` [PATCH v7 4/7] kallsyms: introduce sections needed to map symbols to built-in modules Nick Alcock
2021-12-16 20:19 ` [PATCH v7 5/7] kallsyms: optimize .kallsyms_modules* Nick Alcock
2021-12-16 20:19 ` [PATCH v7 6/7] kallsyms: add /proc/kallmodsyms Nick Alcock
2021-12-16 20:19 ` [PATCH v7 7/7] kallsyms: add reliable symbol size info Nick Alcock
2021-12-19 14:05 ` [kallsyms] a42fff4e29: leaking-addresses.proc.kallmodsyms.0T_stext kernel test robot
2022-01-12 16:30 ` Luis Chamberlain [this message]
2022-01-12 16:59 ` [PING PATCH v7] kallsyms: new /proc/kallmodsyms with builtin modules Nick Alcock
2022-02-02 3:09 ` Luis Chamberlain
2022-02-02 3:39 ` Kris Van Hees
2022-02-02 18:10 ` Daniel Xu
2022-02-03 14:11 ` Nick Alcock
2022-02-02 18:37 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd8CDJA0dy0VaXrB@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=eugene.loh@oracle.com \
--cc=jeyu@kernel.org \
--cc=kris.van.hees@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nick.alcock@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).