[REPOST PATCH v1 0/3] Add support for eDP PHY on SC7280 platform

[REPOST PATCH v1 0/3] Add support for eDP PHY on SC7280 platform

[Douglas Anderson]

This is a repost of the patch series that Sankeerth Billakanti posted
back in November. As Stephen pointed out [1] a few days ago, it wasn't
posted to the right place.

I've tested this and it seems to bring the eDP up on my sc7280 board,
so I'm re-posting it in the hopes that it can land soon-ish unless
there's something terribly wrong with it. ;-)

If it makes folks happier, I have no objections to Sankeerth's
original patches landing. These are the exact same thing but simply
with the addition of my Signed-off-by.

[1] https://lore.kernel.org/r/CAE-0n50sONq+URcWwvDH=UPshgy6+XZEB3sK_4n+5jNktHsEhg@mail.gmail.com


Sankeerth Billakanti (3):
  dt-bindings: phy: Add eDP PHY compatible for sc7280
  phy: qcom: Add support for eDP PHY on sc7280
  phy: qcom: Program SSC only if supported by sink

 Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 4 +++-
 drivers/phy/qualcomm/phy-qcom-edp.c                     | 9 ++++++---
 2 files changed, 9 insertions(+), 4 deletions(-)

-- 
2.35.0.263.gb82422642f-goog

[REPOST PATCH v1 1/3] dt-bindings: phy: Add eDP PHY compatible for sc7280

[Douglas Anderson]

From: Sankeerth Billakanti <quic_sbillaka@quicinc.com>

Add compatible string for the supported eDP PHY on sc7280 platform.

Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
index 9076e19b6417..a5850ff529f8 100644
--- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
@@ -16,7 +16,9 @@ description:
 
 properties:
   compatible:
-    const: qcom,sc8180x-edp-phy
+    enum:
+      - qcom,sc7280-edp-phy
+      - qcom,sc8180x-edp-phy
 
   reg:
     items:
-- 
2.35.0.263.gb82422642f-goog

[REPOST PATCH v1 2/3] phy: qcom: Add support for eDP PHY on sc7280

[Douglas Anderson]

From: Sankeerth Billakanti <quic_sbillaka@quicinc.com>

The sc7280 platform supports native eDP controller and PHY.
This change will add support for the eDP PHY on sc7280.

Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/phy/qualcomm/phy-qcom-edp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
index a8ecd2e8442d..21cafbb623f8 100644
--- a/drivers/phy/qualcomm/phy-qcom-edp.c
+++ b/drivers/phy/qualcomm/phy-qcom-edp.c
@@ -654,6 +654,7 @@ static int qcom_edp_phy_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id qcom_edp_phy_match_table[] = {
+	{ .compatible = "qcom,sc7280-edp-phy" },
 	{ .compatible = "qcom,sc8180x-edp-phy" },
 	{ }
 };
-- 
2.35.0.263.gb82422642f-goog

[REPOST PATCH v1 3/3] phy: qcom: Program SSC only if supported by sink

[Douglas Anderson]

From: Sankeerth Billakanti <quic_sbillaka@quicinc.com>

Some legacy eDP sinks may not support SSC. The support for SSC is
indicated through an opts flag from the controller driver. This
change will enable SSC only if the sink supports it.

Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/phy/qualcomm/phy-qcom-edp.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
index 21cafbb623f8..cacd32f6e0cc 100644
--- a/drivers/phy/qualcomm/phy-qcom-edp.c
+++ b/drivers/phy/qualcomm/phy-qcom-edp.c
@@ -335,9 +335,11 @@ static int qcom_edp_phy_power_on(struct phy *phy)
 	writel(0x00, edp->tx0 + TXn_LANE_MODE_1);
 	writel(0x00, edp->tx1 + TXn_LANE_MODE_1);
 
-	ret = qcom_edp_configure_ssc(edp);
-	if (ret)
-		return ret;
+	if (edp->dp_opts.ssc) {
+		ret = qcom_edp_configure_ssc(edp);
+		if (ret)
+			return ret;
+	}
 
 	ret = qcom_edp_configure_pll(edp);
 	if (ret)
-- 
2.35.0.263.gb82422642f-goog

Re: [REPOST PATCH v1 0/3] Add support for eDP PHY on SC7280 platform

[Vinod Koul]

On 07-02-22, 16:17, Douglas Anderson wrote:
> This is a repost of the patch series that Sankeerth Billakanti posted
> back in November. As Stephen pointed out [1] a few days ago, it wasn't
> posted to the right place.
> 
> I've tested this and it seems to bring the eDP up on my sc7280 board,
> so I'm re-posting it in the hopes that it can land soon-ish unless
> there's something terribly wrong with it. ;-)
> 
> If it makes folks happier, I have no objections to Sankeerth's
> original patches landing. These are the exact same thing but simply
> with the addition of my Signed-off-by.
> 
> [1] https://lore.kernel.org/r/CAE-0n50sONq+URcWwvDH=UPshgy6+XZEB3sK_4n+5jNktHsEhg@mail.gmail.com

Applied all, thanks

-- 
~Vinod